1205825 - avoid redundant monitor acquisitions in MediaCache.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - don't reacquire the media cache's monitor in MediaCacheStream::FlushPartialBlockInternal

FlushPartialBlockInternal is only ever called by methods that are
already holding the MediaCache's monitor.  So we don't need to reacquire
it every time we call this method.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - call Get*CachedData*Internal variants from MediaCacheStream::GetCachedRanges

Each of GetNextCachedData and GetCachedDataEndInternal grab the monitor
on entrance, but GetCachedRanges has already grabbed the monitor for us.
We can call the *Internal variants instead, which assert that the
monitor is held.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/635969c4ca6d
https://hg.mozilla.org/integration/mozilla-inbound/rev/192b893c30ad

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/635969c4ca6d
https://hg.mozilla.org/mozilla-central/rev/192b893c30ad