Closed
Bug 1205825
Opened 9 years ago
Closed 9 years ago
avoid redundant monitor acquisitions in MediaCache.cpp
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(2 files)
1.26 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
1.74 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
FlushPartialBlockInternal is only ever called by methods that are already holding the MediaCache's monitor. So we don't need to reacquire it every time we call this method.
Attachment #8662601 -
Flags: review?(roc)
Assignee | ||
Comment 2•9 years ago
|
||
Each of GetNextCachedData and GetCachedDataEndInternal grab the monitor on entrance, but GetCachedRanges has already grabbed the monitor for us. We can call the *Internal variants instead, which assert that the monitor is held.
Attachment #8662603 -
Flags: review?(roc)
Attachment #8662601 -
Flags: review?(roc) → review+
Attachment #8662603 -
Flags: review?(roc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/635969c4ca6d https://hg.mozilla.org/integration/mozilla-inbound/rev/192b893c30ad
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/635969c4ca6d https://hg.mozilla.org/mozilla-central/rev/192b893c30ad
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•