Initializing gfx info through telemetry takes ~170ms on startup

NEW
Unassigned

Status

()

Core
Graphics
P3
normal
2 years ago
5 months ago

People

(Reporter: Away for a while, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gfx-noted])

It would be great to get a profile with stackwalking and to see if another machine can reproduce it. If it's machine specific it would be useful to get the about:support for catlee' machine.
We can just store the timing in the histogram to confirm how much of an issue this is.

Related:
https://bugzilla.mozilla.org/show_bug.cgi?id=1168591#c5
https://bugzilla.mozilla.org/show_bug.cgi?id=1154500#c4
The profile doesn't have symbols for Firefox? Can you reproduce the issue with a Nightly build and share a profile?
Flags: needinfo?(catlee)
Is this call expensive?
let gfxInfo = Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo);
We make it for each of the 12 fields.
Whiteboard: [gfx-noted]
(Reporter)

Comment 5

2 years ago
(In reply to Milan Sreckovic [:milan] (in Taipei 9/14-9/18) from comment #4)
> Is this call expensive?
> let gfxInfo = Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo);
> We make it for each of the 12 fields.

Given what I can understand from the profile, yes, that is the expensive bit.  It may very well be that the service is initialized once in an expensive way though, I don't think we have any evidence to suggest that the number of callers matters (especially since all but the first caller should just look up the service in a hashtable.)
I can't reproduce this any more
Flags: needinfo?(catlee)
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.