1205846 - Initializing gfx info through telemetry takes ~170ms on startup

Status: NEW

(Core :: Graphics, defect, P3)

Description

[(no longer active)]

This profile has been captured by catlee.

<http://people.mozilla.org/~bgirard/cleopatra/#report=02abd2e22800a7000f9dd043fef4484a6ac4312e&javascriptOnly=true&filter=[{%22type%22%3A%22RangeSampleFilter%22,%22start%22%3A54,%22end%22%3A900}]&selection=0,1103,1132,1136,1137,1141,1142,1148,1149>

Comment 1

[Benoit Girard (:BenWa)]

It would be great to get a profile with stackwalking and to see if another machine can reproduce it. If it's machine specific it would be useful to get the about:support for catlee' machine.

Comment 2

[Vladan Djeric (:vladan)]

We can just store the timing in the histogram to confirm how much of an issue this is.

Related:
https://bugzilla.mozilla.org/show_bug.cgi?id=1168591#c5
https://bugzilla.mozilla.org/show_bug.cgi?id=1154500#c4

Comment 3

[Jeff Muizelaar [:jrmuizel]]

The profile doesn't have symbols for Firefox? Can you reproduce the issue with a Nightly build and share a profile?

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Is this call expensive?
let gfxInfo = Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo);
We make it for each of the 12 fields.

Comment 5

[(no longer active)]

(In reply to Milan Sreckovic [:milan] (in Taipei 9/14-9/18) from comment #4)
> Is this call expensive?
> let gfxInfo = Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo);
> We make it for each of the 12 fields.

Given what I can understand from the profile, yes, that is the expensive bit.  It may very well be that the service is initialized once in an expensive way though, I don't think we have any evidence to suggest that the number of callers matters (especially since all but the first caller should just look up the service in a hashtable.)

Comment 6

[Chris AtLee [:catlee]]

I can't reproduce this any more