Closed Bug 1205887 Opened 4 years ago Closed 4 years ago

Verify that MOZILLA_VERSION was set correctly

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file, 2 obsolete files)

Figuring out MOZILLA_VERSION depends on $PYTHON being set, which seems easy to accidentally reorder (since it's happened a few times.)
Complain bitterly if it does, instead of silently setting MOZILLA_VERSION and friends to the empty string.
Attachment #8662672 - Flags: review?(mh+mozilla)
Comment on attachment 8662672 [details] [diff] [review]
Verify that MOZILLA_VERSION was set correctly

Review of attachment 8662672 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +699,5 @@
>  
>  dnl ==============================================================
>  dnl Get mozilla version from central milestone file
>  dnl ==============================================================
> +AC_MSG_CHECKING([mozilla version])

I don't think the AC_MSG_CHECKING/AC_MSG_RESULT bits are useful.

@@ +705,5 @@
>  MOZILLA_UAVERSION=`$PYTHON $srcdir/python/mozbuild/mozbuild/milestone.py --topsrcdir $srcdir --uaversion`
>  MOZILLA_SYMBOLVERSION=`$PYTHON $srcdir/python/mozbuild/mozbuild/milestone.py --topsrcdir $srcdir --symbolversion`
> +if test -z "$MOZILLA_VERSION"; then
> +  AC_MSG_ERROR([failed to read from milestone file])
> +fi

Please add the same to configure.in
Attachment #8662672 - Flags: review?(mh+mozilla) → feedback+
Ok, trimmed down to only catch the problematic error instead of complaining mysteriously about $PYTHON.
Attachment #8670101 - Flags: review?(mh+mozilla)
Attachment #8662672 - Attachment is obsolete: true
Comment on attachment 8670101 [details] [diff] [review]
Verify that MOZILLA_VERSION was set correctly

Review of attachment 8670101 [details] [diff] [review]:
-----------------------------------------------------------------

Second part of comment 2 still applies.
Attachment #8670101 - Flags: review?(mh+mozilla) → feedback+
Right, sorry. That's what I get for skimming through this in a batch of other things.
Attachment #8670504 - Flags: review?(mh+mozilla)
Attachment #8670101 - Attachment is obsolete: true
Attachment #8670504 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/69d7962bde8e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.