Closed Bug 1205907 Opened 9 years ago Closed 9 years ago

Intermittent activities_test.js | Contacts > Activities webcontacts/email activity Creates only one instance of action menu

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86_64
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philor, Assigned: julienw)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

[gaia] julienw:1205907-fix-contacts-marionette-test > mozilla-b2g:master
46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review 
      No description provided.
Summary: Intermittent /activities_test.js | Contacts > Activities webcontacts/email activity Creates only one instance of action menu → Intermittent activities_test.js | Contacts > Activities webcontacts/email activity Creates only one instance of action menu
Blocks: 1222215
This is one of our top intermittents. Could you guys help out?
Flags: needinfo?(francisco)
Flags: needinfo?(felash)
I can take it, it consistently fail for me locally.
Assignee: nobody → felash
Flags: needinfo?(felash)
So, it looks like the click handler for the "add email" link is not registered when we tap on it, on a fast machine. But I don't yet understand how this can happen.
Replacing `.click()` by `.scriptWith(function(el) { el.click(); })` in Contacts.addContactMultipleEmails works better, but I don't understand why...
Comment on attachment 8685704 [details] [review]
[gaia] julienw:1205907-fix-contacts-marionette-test > mozilla-b2g:master

Hey Johan,

I admit I don't understand what I'm doing here, but it's fixing the problem.

I'd like to have your expert advice on why this could fix the issue.
Attachment #8685704 - Flags: feedback?(jlorenzo)
If .click() is implemented using [1] (the "clickElement" marionette command), it seems it actually wants to simulate a real mouse click.

It's actually way different than calling ".click()" (which is using the DOM API).

[1] https://github.com/SeleniumHQ/selenium/blob/9d157ae962ad5857ff28e7cbedcc0d57fd30d143/javascript/firefox-driver/js/wrappedElement.js#L63
I think I have a clue: when displaying the "add contact" panel, we have a transition happening, and while it's happening nothing happens when I tap the "add email" (even when trying manually). I suspect this is happening here.
Attachment #8685704 - Flags: feedback?(jlorenzo)
Flags: needinfo?(francisco)
Comment on attachment 8685704 [details] [review]
[gaia] julienw:1205907-fix-contacts-marionette-test > mozilla-b2g:master

Hey Francisco,

I didn't understand why we have "pointer-events: none" on the "next" panel, I think we shouldn't have it. So I removed it and it fixes the issue for me :)

(I totally understand we have it on the "current" panel though).

Note the integration test failure happens when the computer is too quick (contrary to other intermittent we see :) ).
Attachment #8685704 - Flags: review?(francisco)
Comment on attachment 8685704 [details] [review]
[gaia] julienw:1205907-fix-contacts-marionette-test > mozilla-b2g:master

Was tracking why we added that and come from:

https://bugzilla.mozilla.org/show_bug.cgi?id=935307

But right now with the current views (even without splitting), that's not needed anymore.

Tested on the phone and looking good, also tried to repro bug 935307 and couldn't so r+ on my side.

Thanks for the patch!
Attachment #8685704 - Flags: review?(francisco) → review+
Wow, if this is a patch for bug 935307, this looks a lot like a workaround :) anyway we still block pointer events for the prev panel.

Thanks !
master: 2a5d9511103e129473591043568c426f8f14f5f8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Should this be uplifted to the nga branch as well ? (I can do it, I just want to know if necessary :) )
Flags: needinfo?(francisco)
Yes please, we still use that navigation object for subviews (like the search one in the list, or the import in settings)

Thanks again.
Flags: needinfo?(francisco)
nga: 807ed988e6d4736851680fe6ad27b934be02c24f
From the graph, it's 0 occurences since November 19th. \o/

b2g-inbound stops November 16th and then I guess we needed to wait for the patch propagation.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: