1205909 - Remove the remnants of IsNullTaggedPointer

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: remove_isNullTaggedPointer_remnants-v0.diff

With TaggedProto working like a normal tagged pointer, we no longer have a need for IsNullTaggedPointer, isMarkableTaggedPointer, and isNullLike.

 7 files changed, 3 insertions(+), 30 deletions(-)

Comment 1

[Terrence Cole [:terrence]]

Comment on attachment 8662700 [details] [diff] [review]
remove_isNullTaggedPointer_remnants-v0.diff

Uhg, this fails in zeal tests because we actually put a tagged shape on the stack. Need to fix that first.

Comment 2

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6435a8e93af6

Comment 3

[Terrence Cole [:terrence]]

I wish I'd taken better notes! In any case, another try run to see if whatever is still an issue.

Comment 4

[Terrence Cole [:terrence]]

The code in question is here: http://searchfox.org/mozilla-central/rev/6b94deded39a868f248a492e74e05733d6c4ed48/js/src/vm/Shape.h#1413

That is: MarkNonNativePropertyFound.

Comment 5

[Terrence Cole [:terrence]]

Unfortunately, the type of the maybe-marked-as-non-native shape leaks out into the friend API, so fixing this means we need to fix the hook somehow. We could probably also fix this directly in the compiler. In any case, I don't have time to work on it.

Comment 6

[Jon Coppeard (:jonco)]

Attachment: bug1205909-rm-isNullTaggedPointer-remnants

Rebased patch to remove this.

Tests now pass with the patch in bug 1331668 applied.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5daa748c344d
Remove the now-unused portions of IsNullTaggedPointer r=sfink

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5daa748c344d