Closed Bug 1205909 Opened 9 years ago Closed 7 years ago

Remove the remnants of IsNullTaggedPointer

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox43 --- affected
firefox54 --- fixed

People

(Reporter: terrence, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

With TaggedProto working like a normal tagged pointer, we no longer have a need for IsNullTaggedPointer, isMarkableTaggedPointer, and isNullLike.

 7 files changed, 3 insertions(+), 30 deletions(-)
Attachment #8662700 - Flags: review?(sphink)
Comment on attachment 8662700 [details] [diff] [review]
remove_isNullTaggedPointer_remnants-v0.diff

Uhg, this fails in zeal tests because we actually put a tagged shape on the stack. Need to fix that first.
Attachment #8662700 - Flags: review?(sphink)
I wish I'd taken better notes! In any case, another try run to see if whatever is still an issue.
The code in question is here: http://searchfox.org/mozilla-central/rev/6b94deded39a868f248a492e74e05733d6c4ed48/js/src/vm/Shape.h#1413

That is: MarkNonNativePropertyFound.
Unfortunately, the type of the maybe-marked-as-non-native shape leaks out into the friend API, so fixing this means we need to fix the hook somehow. We could probably also fix this directly in the compiler. In any case, I don't have time to work on it.
Assignee: terrence → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jcoppeard)
Depends on: 1325406
Flags: needinfo?(jcoppeard)
Depends on: 1331668
Rebased patch to remove this.

Tests now pass with the patch in bug 1331668 applied.
Assignee: nobody → jcoppeard
Attachment #8662700 - Attachment is obsolete: true
Attachment #8827536 - Flags: review?(sphink)
Attachment #8827536 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5daa748c344d
Remove the now-unused portions of IsNullTaggedPointer r=sfink
https://hg.mozilla.org/mozilla-central/rev/5daa748c344d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.