1205924 - Implement navigation bar for nested bookmark folders

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Richard Newman [:rnewman]]

Right now we support nested folder navigation… but there's no back button and no folder title. We need to fix that for this feature to be useful.

This is immediately actionable: just switch out the data source in BookmarksPanel:

  profile.bookmarks.modelForFolder(BookmarkRoots.MobileFolderGUID).upon(onModelFetched)

  //profile.bookmarks.modelForRoot().upon(onModelFetched)

^^^

and you'll be able to repro.

Someone other than me should pick this up; I can rebase it on top of my changes in Bug 1201104 and Bug 1201108 and Bug 1201109.

Comment 1

[Richard Newman [:rnewman]]

Robin, do you already have mocks for this? If not, do you have time to put something together? I expect this to be tracking-1.1.

Comment 2

[Robin Andersen [:tecgirl]]

(In reply to Richard Newman [:rnewman] from comment #1)
> Robin, do you already have mocks for this? If not, do you have time to put
> something together? I expect this to be tracking-1.1.

I don't have mocks yet but I can put something together.

Comment 3

[Robin Andersen [:tecgirl]]

Attachment: Image 2015-09-28 at 1.32.05 PM.png

Bookmark folder mocks

Comment 4

[Robin Andersen [:tecgirl]]

Attachment: bookmarkFolder.zip

Bookmark Folder assets

Comment 5

[Richard Newman [:rnewman]]

I have these landed in my stack. Thanks for the quick turnaround!

Comment 6

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 8669109 [details] [review]
Pull request

I left some questions and pointers to conflicting commits from the big bookmark sync PR on this PR.

Comment 8

[Richard Newman [:rnewman]]

Landed new assets (and removed the old) as part of my landing:

675ed95

Comment 9

[Richard Newman [:rnewman]]

Comment on attachment 8669109 [details] [review]
Pull request

This works. It doesn't match the mocks, but it's a thousand times better than the broken state it replaces, so I landed it: 751bfbe.

We can iterate in-tree.