Closed Bug 1205938 Opened 9 years ago Closed 8 years ago

Enable fullscreen-api-race test on e10s

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
e10s + ---
firefox43 --- affected
firefox49 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

      No description provided.
Depends on: 1196159
Depends on: 1206559
Blocks: e10s-tests
tracking-e10s: --- → +
Depends on: 1212692
Blocks: fullscreen-api
No longer blocks: 1191597
Blocks: 1215369
No longer blocks: fullscreen-api
Flags: needinfo?(quanxunzhen)
Try push looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d8b4c64969b
Flags: needinfo?(bugzilla)
This function is roughly copied from browser/base/content/test/general/head.js.
It has been widely used in browser chrome mochitests, and should be fine to
have it available to all mochitests via SimpleTest.

Review commit: https://reviewboard.mozilla.org/r/50305/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50305/
Attachment #8748468 - Flags: review?(jmaher)
Attachment #8748469 - Flags: review?(bugs)
Comment on attachment 8748469 [details]
MozReview Request: Bug 1205938 part 2 - Enable fullscreen-api-race test on e10s and OS X. r?smaug

https://reviewboard.mozilla.org/r/50307/#review47155
Attachment #8748469 - Flags: review?(bugs) → review+
Comment on attachment 8748468 [details]
MozReview Request: Bug 1205938 part 1 - Add waitForCondition() function to SimpleTest. r?jmaher

https://reviewboard.mozilla.org/r/50305/#review47335

this looks like a simple move of a function into simpletest- I have no issues with it.  Can we have a unittest for this?  we have testing/tests/Harness_sanity/test_*.html to test some of the simpletest functions- it would be nice to get basic coverage- ok with a followup bug.
Attachment #8748468 - Flags: review?(jmaher) → review+
Blocks: 1270301
Assignee: nobody → bugzilla
https://hg.mozilla.org/mozilla-central/rev/8710b9ecc282
https://hg.mozilla.org/mozilla-central/rev/7144610b5ce1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: