Closed Bug 1205985 Opened 9 years ago Closed 3 years ago

Add Telemetry measurement for the time Firefox was open and the computer not in sleep

Categories

(Toolkit :: Telemetry, defect, P4)

defect

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox43 --- wontfix
firefox86 --- fixed

People

(Reporter: gfritzsche, Assigned: padenot)

References

Details

(Whiteboard: [measurement:client])

Attachments

(4 files, 2 obsolete files)

Our current time measurements (totalTime, (sub)sessionLength) are supposed to measure absolute time since Firefox was started, including time the computer was in sleep.

activeTicks measures the time Firefox was actively used.

We should add a measurement for the time Firefox was open and the computer not in sleep (independent of active usage).
Also note the discussions in bug 1205567 and bug 1219315.
See Also: → 1205567, 1219315
Priority: -- → P3
Whiteboard: [measurement:client]
Priority: P3 → P4
See Also: → 1485692

https://github.com/python-trio/trio/issues/1586 has some details about clock behavior with respect to sleep on different platforms.

Assignee: nobody → padenot

I need to check if it's OK to drop this inconsistent boolean. It's OK on
Windows 10, but I need to check on Windows 7.

Depends on D99138

Attachment #9192045 - Attachment description: Bug 1205985 - Implement something to get the process uptime with and without the time the device was suspended. r?haik,dmajor,jld → Bug 1205985 - Implement something to get the process uptime with and without the time the device was suspended. r?haik!,dmajor!,jld!
Attachment #9190616 - Attachment is obsolete: true
Attachment #9192230 - Flags: data-review?(chutten)

Comment on attachment 9192230 [details]
Bug 1205985 - Add two new scalars to record the session time with and without counting the time the device was suspended r?chutten! data-review=chutten

The Data Review process involves filling out the Data Review Request and placing data-review? on it for a Data Steward. Full documentation is available here: https://wiki.mozilla.org/Firefox/Data_Collection

Attachment #9192230 - Flags: data-review?(chutten)

Comment on attachment 9192230 [details]
Bug 1205985 - Add two new scalars to record the session time with and without counting the time the device was suspended r?chutten! data-review=chutten

Request for data collection review form

  1. What questions will you answer with this data?

How long do Firefox instances run for, with and without suspend, in milliseconds.

  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:

We've been measuring this for ages, but not correctly.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?

No alternative, what exists is wrong.

  1. Can current instrumentation answer these questions?

No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

<table>
<tr>
<td>Measurement Description</td>
<td>Data Collection Category</td>
<td>Tracking Bug #</td>
</tr>
<tr>
<td>Duration, in millisecond, of a Firefox instance session including the time the device was suspended</td>
<td> Category 2 “Interaction data”</td>
<td>1205985</td>
</tr>
<tr>
<td>Duration, in millisecond, of a Firefox instance session excluding the time the device was suspended</td>
<td> Category 2 “Interaction data”</td>
<td>1205985</td>
</tr>
</table>

  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.

This collection is documented in its definitions files Scalars.yaml.

  1. How long will this data be collected? Choose one of the following:

For ever, and potentially promoted off a regular scalar if that makes sense.

  1. What populations will you measure?

Everybody.

  1. If this data collection is default on, what is the opt-out mechanism for users?

Disabling telemetry.

  1. Please provide a general description of how you will analyze this data.

For the "including suspend" probe, comparing to the session time on Windows (should be equivalent). For the other one, comparing to the session time on Linux/macOS (also should be equivalent on those platforms). Then, comparing both on the same platform, and making sure the first probe value is always bigger than the second probe value.

  1. Where do you intend to share the results of your analysis?

This probe is probably not going to be used in itself (although it might be interesting). We need this to compute other metrics, and this will probably happen in a private document shared with a selected number of people.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? If so:

No.

Attachment #9192230 - Flags: data-review?(chutten)
Attachment #9192230 - Flags: data-review?(chutten)
Attached file data collection review

PRELIMINARY NOTES:
For future data collection reviews, please paste the review request into a file attachment (it makes Data Stewards' lives a little easier). I've done so here for consistent record-keeping.

For permanent data collections it is required that an individual be responsible for the collection. Since it's your email address on the probes, I'll move forward assuming :padenot's the one interested in the health of these probes over time. If this is in error, please mention in the bug which individual will own this permanent collection and take this data-review+ to still be valid.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :padenot is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.


Result: datareview+

Attachment #9193283 - Flags: data-review+
Attachment #9192230 - Attachment description: Bug 1205985 - Add two new scalars to record the session time with and without counting the time the device was suspended r?chutten! data-review?chutten → Bug 1205985 - Add two new scalars to record the session time with and without counting the time the device was suspended r?chutten! data-review=chutten
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ba60febbcf8
Implement something to get the process uptime with and without the time the device was suspended. r=haik,dmajor,jld
https://hg.mozilla.org/integration/autoland/rev/89b03879ce7d
Plumb the new uptime functions to telemetry code. r=chutten
https://hg.mozilla.org/integration/autoland/rev/f82f5070bee5
Add two new scalars to record the session time with and without counting the time the device was suspended r=chutten data-review=chutten
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d540daa09b9
Implement something to get the process uptime with and without the time the device was suspended. r=haik,dmajor,jld
https://hg.mozilla.org/integration/autoland/rev/ed379c368f0e
Plumb the new uptime functions to telemetry code. r=chutten
https://hg.mozilla.org/integration/autoland/rev/017e8a6245b2
Add two new scalars to record the session time with and without counting the time the device was suspended r=chutten data-review=chutten
Regressions: 1686405
Attachment #9195863 - Attachment is obsolete: true
Flags: needinfo?(padenot)
You need to log in before you can comment on or make changes to this bug.