1206044 - [Flame][Music NGA&OGA]Music controls are usabled during a call .

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: AudioChannel, defect, P2)

Description

[zouyi(Leave from Mozilla)]

[1.Description]:
[Flame KK v2.5][Music NGA]When the user is on a call, music controls are usabled in the music app. 
Found time:17:50.
See attachment:logcat_1750.txt, Flame KK v2.5.3gp.

[2.Testing Steps]: 
1. Enter a phone call with another device. 
2. Once the call is established, tap the Home button and launch the Music NGA. 
3. Select a song and play it. 

[3.Expected Result]: 
3.Music controls are disabled.

[4.Actual Result]: 
3.Music controls are usabled and the music can be played.

[5.Reproduction build]: 
Flame KK v2.5(Affected)
Build ID               20150917150223
Gaia Revision          aede8622d780ec71f766a3ecccbff74c04aaba4e
Gaia Date              2015-09-17 03:40:46
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3929b8fc6c33bf9cc80299743063f0981f545452
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150917.183330
Firmware Date          Thu Sep 17 18:33:40 EDT 2015
Bootloader             L1TC000118D0


[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
13220

Comment 1

[zouyi(Leave from Mozilla)]

Attachment: logcat_1750.txt

Comment 2

[zouyi(Leave from Mozilla)]

Attachment: Flame KK v2.5.3gp

Comment 3

[William Hsu [:whsu]]

Hi, Zouyi,

Can it be reproduced on "Music" app (The old one)?

Comment 4

[Hema Koka [:hema]]

Seems like a audio channel issue...

Comment 5

[Justin D'Arcangelo [:justindarc]]

The UI for this has not yet been implemented. The hooks, however, are already in place. I'll have a patch ready soon.

Comment 6

[zouyi(Leave from Mozilla)]

Hi William,
The bug can be reproduced on latest build of Flame KK v2.5 with "Music" app (The old one) by STR in comment 0.

Actual results: Music controls are usabled and the music can be played.
See attachments: logcat_1205.txt, Flame KK v2.5.3gp.
Reproduce rate: 10/10

Device: Flame KK 2.5(Affected)
Build ID               20150920150205
Gaia Revision          e67d319d0854e32e23210784eb9c4e1b8a025adb
Gaia Date              2015-09-19 07:42:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccd6b5f5e544c1d708849144943a776941bd3794
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150920.182952
Firmware Date          Sun Sep 20 18:30:04 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 7

[zouyi(Leave from Mozilla)]

Attachment: logcat_1205.txt

Comment 8

[zouyi(Leave from Mozilla)]

Attachment: Flame KK v2.5.3gp

Comment 9

[Jim Porter (:squib)]

Justin: you probably need checkSCOStatus from OGA's player_view.js

Comment 10

[Justin D'Arcangelo [:justindarc]]

(In reply to Jim Porter (:squib) from comment #9)
> Justin: you probably need checkSCOStatus from OGA's player_view.js

squib: Yeah, we are doing that already. This is also affecting OGA. I'm guessing this is an AudioChannel bug. You can listen to your music while you're on a call. Maybe its a feature ;-)

Comment 11

[Jim Porter (:squib)]

Ok, if this is on both versions of the app, we can probably just shunt this off into the AudioChannel garbage pile. :)

Comment 12

[Justin D'Arcangelo [:justindarc]]

Re-assigning to AudioChannel. SCOStatus doesn't seem to be getting set properly.

Comment 13

[Hema Koka [:hema]]

[Blocking Requested - why for this release]:

Comment 14

[Bobby Chien]

Alastor, could you help on this? Thanks.

Comment 15

[Alastor Wu [:alwu]]

Hi, zouyi,
You said that "Music controls are disabled", do you expect the music can't be playback during the call?
However, from the UX spec [1], we can play the music during the call.

[1] https://bug1068219.bmoattachments.org/attachment.cgi?id=8579177#12

Comment 16

[Justin D'Arcangelo [:justindarc]]

(In reply to Alastor Wu [:alwu] from comment #15)
> Hi, zouyi,
> You said that "Music controls are disabled", do you expect the music can't
> be playback during the call?
> However, from the UX spec [1], we can play the music during the call.
> 
> [1] https://bug1068219.bmoattachments.org/attachment.cgi?id=8579177#12

Oh wow. I'm really surprised that we expect to be able to play music while on a phone call. If that's the case, per the UX spec, then that's exactly what the app is currently doing. I guess I can play "please wait" elevator music for my callers now :-)

Just to be safe, flagging :jsavory for UX input on this. Should we allow music to be played while on a phone call?

Comment 17

[Bobby Chien]

Per comment 15, current scenario follows UX spec. Close bug as WONTFIX.

Comment 18

[Jim Porter (:squib)]

(In reply to Alastor Wu [:alwu] from comment #15)
> Hi, zouyi,
> You said that "Music controls are disabled", do you expect the music can't
> be playback during the call?
> However, from the UX spec [1], we can play the music during the call.
> 
> [1] https://bug1068219.bmoattachments.org/attachment.cgi?id=8579177#12

Where do you see that in the attachment? I see this: "FM/Music: Paused and UI disabled during a call. FM/Music resumes after the call."

Comment 19

[Alastor Wu [:alwu]]

I see that from the competing table, when "content" comes in during the "telephony", the result is "PLAY both the current and the new channels".

Comment 20

[Jim Porter (:squib)]

Ok, sounds good to me. The spec just seems to contradict itself a bit...

Comment 21

[Bobby Chien]

Jim, could you share what you think of UX spec? we can request UX team to get feedback on this. Thanks.

Comment 22

[Jim Porter (:squib)]

I don't have a strong opinion on it, but the quote I referenced in comment 18 contradicts the quote from comment 19.

Comment 23

[Jacqueline Savory [:jsavory] UX]

It looks to me like the note that Jim mentions in comment 18 is trying to say that music should be disabled during a call, despite it being contradicted in the table. I don't really see a use case for playing music during a call so I would probably say we should disable it. 

However, being able to play music during a call isn't necessarily a bad experience either, so I would say that if its a lot of effort to change, we can leave it as is.