1206049 - Default theme getting marked as incompatible, breaking the default theme overrides and leading to broken browser appearance

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Tim Nguyen :ntim]

Attachment: addon-manager-incompatibility-notice.png

Comment 1

[Tim Nguyen :ntim]

Attachment: about-support.txt

Comment 2

[Tim Nguyen :ntim]

Attachment: about-buildconfig.txt

Comment 3

[Tim Nguyen :ntim]

Attachment: safe-mode.PNG

Overrides work fine in safe mode (the profile only has MS .NET assistant as addon)

Comment 4

[Tim Nguyen :ntim]

(In reply to Tim Nguyen [:ntim] from comment #0)
> Created attachment 8662902 [details]
> addon-manager-incompatibility-notice.png

Note that this *is* the default theme (there are no other themes installed) on the profile.

Comment 5

[Tim Nguyen :ntim]

Note that resetting another affected profile fixed the issue.

Comment 6

[Tim Nguyen :ntim]

Also, this is affecting a lot of profiles running on Windows XP on my school network. My personal copy of Nightly (which has a custom profile) isn't affected though.

Comment 7

[Tim Nguyen :ntim]

(In reply to Tim Nguyen [:ntim] from comment #6)
> Also, this is affecting a lot of profiles running on Windows XP
Actually, some profiles are also affected on Windows 7.

Comment 8

[:Gijs (he/him)]

It seems pretty straightforward that what's going on here is that the default theme is somehow marked as incompatible. That should never happen, and that it's happening is not a theme but an add-on manager bug, and the solution is going to involve figuring out why the ... the default theme is marked as incompatible.

Dave, can you suggest ways of figuring out *why* this is happening on the affected profiles?

Comment 9

[Dave Townsend [:mossop]]

(In reply to Tim Nguyen [:ntim] from comment #0)
> Created attachment 8662902 [details]
> addon-manager-incompatibility-notice.png

Something strange is going on here. This theme has version 2.0? That isn't the theme that ships with Firefox 40 so I'm not surprised it shows up as incompatible. That said, regardless of the compatibility information in the theme the default theme should always be usable: https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIProvider.jsm#611.

What is the value of general.skins.selectedSkin in this profile (we should probably have that in about:support!)

Attaching a copy of extensions.json from the affected profile might be interesting.

Comment 10

[:Gijs (he/him)]

(In reply to Dave Townsend [:mossop] from comment #9)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > Created attachment 8662902 [details]
> > addon-manager-incompatibility-notice.png
> 
> Something strange is going on here. This theme has version 2.0? That isn't
> the theme that ships with Firefox 40 so I'm not surprised it shows up as
> incompatible. That said, regardless of the compatibility information in the
> theme the default theme should always be usable:
> https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/
> internal/XPIProvider.jsm#611.
> 
> What is the value of general.skins.selectedSkin in this profile (we should
> probably have that in about:support!)
> 
> Attaching a copy of extensions.json from the affected profile might be
> interesting.

Comment 11

[Tim Nguyen :ntim]

Attachment: extensions.json

general.skins.selectedSkin = classic/1.0

Comment 12

[Dave Townsend [:mossop]]

(In reply to Tim Nguyen [:ntim] from comment #11)
> Created attachment 8665964 [details]
> extensions.json

This shows that you have a copy of the default theme installed in the profile, it is overriding the one shipped with the app and will be why everything seems broken.

Comment 13

[:Gijs (he/him)]

(In reply to Dave Townsend [:mossop] from comment #12)
> (In reply to Tim Nguyen [:ntim] from comment #11)
> > Created attachment 8665964 [details]
> > extensions.json
> 
> This shows that you have a copy of the default theme installed in the
> profile, it is overriding the one shipped with the app and will be why
> everything seems broken.

Did we used to put it there in Firefox... 2.0 ? (cf. comment #9)
Maybe we should write a startup migration to get rid of these... all they're going to do is cause issues...

Comment 14

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #13)
> (In reply to Dave Townsend [:mossop] from comment #12)
> > (In reply to Tim Nguyen [:ntim] from comment #11)
> > > Created attachment 8665964 [details]
> > > extensions.json
> > 
> > This shows that you have a copy of the default theme installed in the
> > profile, it is overriding the one shipped with the app and will be why
> > everything seems broken.
> 
> Did we used to put it there in Firefox... 2.0 ? (cf. comment #9)
> Maybe we should write a startup migration to get rid of these... all they're
> going to do is cause issues...

well, I guess more generally, nothing in the profile directory should be allowed to override the builtin default theme...

Comment 15

[Dave Townsend [:mossop]]

(In reply to :Gijs Kruitbosch from comment #13)
> (In reply to Dave Townsend [:mossop] from comment #12)
> > (In reply to Tim Nguyen [:ntim] from comment #11)
> > > Created attachment 8665964 [details]
> > > extensions.json
> > 
> > This shows that you have a copy of the default theme installed in the
> > profile, it is overriding the one shipped with the app and will be why
> > everything seems broken.
> 
> Did we used to put it there in Firefox... 2.0 ? (cf. comment #9)
> Maybe we should write a startup migration to get rid of these... all they're
> going to do is cause issues...

Not to my knowledge. If this were the case I think we'd have seen a lot of problems from it years ago. I have no idea how this profile ended up in this state.

Comment 16

[Tim Nguyen :ntim]

In bug 1191468, it looks like the affected profile doesn't have the default theme installed.

Comment 17

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.