Closed Bug 1206060 Opened 4 years ago Closed 4 years ago

Add pinning status to about:cache

Categories

(Core :: Networking: Cache, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox43 --- affected
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — Splinter Review
Attachment #8665451 - Flags: review?(michal.novotny)
Comment on attachment 8665451 [details] [diff] [review]
v1

Review of attachment 8665451 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/cache2/CacheFileContextEvictor.cpp
@@ +295,5 @@
>    nsresult rv;
>  
> +  /// TEST
> +  return NS_OK;
> +  /// TEST

I guess this shouldn't be in the final patch :)
Attachment #8665451 - Flags: review?(michal.novotny) → review+
Attached patch v1.1Splinter Review
- rebased
- test code removed
Attachment #8665451 - Attachment is obsolete: true
Attachment #8681300 - Flags: review+
This patch doesn't need a try run since I don't know about a test that would rely on _content_ of about:cache* pages.  Hence I'm asking for check-in w/o wasting a whole try run.  If it's not an option I can push, tho.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b531b32383d4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.