1206073 - Can't run various tests due to importing of resource://testing-common/... failing

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Mark Banner (:standard8)]

I've just tracked this down to bug 1193257.

On my latest Fx-team build on Mac (no debug, optimized, with ccache), I was trying to run xpcshell-tests for a specific directory and this is what I'm getting:

$ ./mach xpcshell-test browser/components/loop/
...
 0:02.08 TEST_START: Thread-47 browser/components/loop/test/xpcshell/test_loopservice_restart.js
 0:02.23 TEST_END: Thread-47 FAIL, expected PASS
xpcshell return code: 0
 0:02.23 LOG: Thread-47 INFO >>>>>>>
 0:02.21 LOG: Thread-47 ERROR NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
@/Users/mark/loop/gecko-dev/objdir-ff/_tests/xpcshell/browser/components/loop/test/xpcshell/head.js:14:1
load_file@/Users/mark/loop/gecko-dev/testing/xpcshell/head.js:602:7
_load_files@/Users/mark/loop/gecko-dev/testing/xpcshell/head.js:614:3
_execute_test@/Users/mark/loop/gecko-dev/testing/xpcshell/head.js:494:3
@-e:1:1

 0:02.21 LOG: Thread-47 INFO (xpcshell/head.js) | test MAIN run_test pending (1)
 0:02.21 LOG: Thread-47 ERROR ReferenceError: HttpServer is not defined at /Users/mark/loop/gecko-dev/objdir-ff/_tests/xpcshell/browser/components/loop/test/xpcshell/head.js:47
setupFakeLoopServer@/Users/mark/loop/gecko-dev/objdir-ff/_tests/xpcshell/browser/components/loop/test/xpcshell/head.js:47:3
run_test@/Users/mark/loop/gecko-dev/objdir-ff/_tests/xpcshell/browser/components/loop/test/xpcshell/test_loopservice_restart.js:111:3
_execute_test@/Users/mark/loop/gecko-dev/testing/xpcshell/head.js:510:7
@-e:1:1

 0:02.23 LOG: Thread-47 INFO <<<<<<<

In this case its:

Cu.import("resource://testing-common/httpd.js");

that fails, but I've seen it for other testing-common resources as well.

Comment 1

[Andrew Halberstadt [:ahal]]

This is probably a regression in the mach_commands.py, otherwise it would be failing in automation too. The "resource://testing-common" url gets set up by the 'testingModulesDir' variable, so likely that isn't getting set properly anymore.

Does running:
$ ./mach xpcshell-test browser/components/loop --testing-modules-dir <objdir>/_tests/modules

fix the problem? I'll rebuild and test it out myself in a bit.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1206073 - [xpcshell] Fix default value for testingModulesDir when running from mach, r=jgraham

Bug 1206073 - [xpcshell] Fix default value for testingModulesDir when running from mach, r=jgraham

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8662941 [details]
MozReview Request: Bug 1206073 - [xpcshell] Fix default value for testingModulesDir when running from mach, r=jgraham

https://reviewboard.mozilla.org/r/19675/#review17701

Thanks.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ea485aa45da

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ea485aa45da