1206100 - Panels anchor at different heights on Windows

Status: RESOLVED DUPLICATE of bug 1033395

(Firefox :: Theme, defect, P4)

Description

[u428464]

Attachment: Three panels example.png

The panels on Windows anchor at different heights with their respective toolbar buttons. There are at least three anchor placements on Windows.
1. The main menu and Hello panels arrow is slightly covering the buttons.
2. The "show your bookmarks" panel arrow is a bit lower.
3. Almost all other panels have the arrow just touching the base of their respective buttons.

All the arrow should anchor at the same height.

Comment 1

[:Gijs (he/him)]

I can't reproduce this on Windows 8 with Firefox 41. Is this a regression, or win10-specific? Which builds does this happen on?

Comment 2

[u428464]

I don't really think it's Windows 10 specific, but I think the issue appears in Firefox 43.

Comment 3

[u428464]

Firefox 42 seems to be affected as well.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I was able to reproduce on Win10 x64.

The difference in panel height with the hamburger menu vs. the other buttons appears to be longstanding (I just reproduced it on a nightly build from last December during the Fx37 dev cycle). So for the purposes of this bug, I'm ignoring that difference for regression range finding purposes. Not saying it isn't an issue in general, though :)

I was able to reproduce a change in behavior with the downloads and bookmarks dropdowns, however. They used to both be at the same starting point flush with the bottom of the button (similar to how the downloads button is shown in the attached screenshot). Bisection on that regression points to bug 1179295.

The Hello panel actually appears to have regressed at a different point. Bisection on that one points to bug 1029937 as the cause.

I'm not sure if it makes sense to try to fix both issues in this bug or to split them out into different ones. Dao/Neil? :)

Comment 6

[Markus Jaritz [:designakt] (UX)]

The dup got pixel values for the offset in it. 
Maybe this helps make this fix easier.

(In reply to Markus Jaritz [:maritz] (UX) from comment #0)
> Created attachment 8677022 [details]
> PanelPositionsOff.gif
> 
> Bookmark-panel  is positioned 2px too low, and 1px too far right,
> Pocket-panel    is positioned 5px too low,
> Downloads-panel is positioned 5px too low, and 1px too far right.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

This isn't Windows-specific, since we see the same behaviour on OS X, and probably Linux, though I admit to not having checked there yet.

Comment 10

[Stephen Horlander [:shorlander]]

For the toolbar we should anchor the panels off of the bottom of the 16 x 16 icon area. This would create a partial overlap of the panel arrow and the visible button area and address the consistency issues.

Comment 11

[Roman Müller]

This comment is going to contain some serious hate towards your company. With every single update on Nightly for last few weeks I'm finding sloppy job here and there... Few days ago you removed possibility to move refresh button around. I was used to have refresh button on the other side of whole screen for years, but now I can't... at least I still move that useless pocket button around and basically any other button. But nope to refresh button. I don't get it but whatver... got used to it. They few days later, your removed bookmarking feature from bookmarks icon and moved it also to the location bar on the other side of whole window without option to move it around. Now Im seriously getting **** of. You know what? WHy dont you remove whole Customize feature and move ALL available buttons to that damn location bar... because Customize is obviously useless.

Well I guess I could move these buttons around with some little help of addons, even tho I very dislike idea of installing whole addon full very unnecessary and potentialy defective code just to move damn refresh button around... but waaait a moment. I almost forgot that all my addons and basically any other addons will cease to wrok with 57 release!

http://fii.cz/ykhwtbbu

And now we are getting to explanation why I type all of this to this bug. I wasn't even surprised you was't able to get the panel anchor right even this time. The fact how it is anchored is however very amusing.

http://fii.cz/xbuxtcph

Good job, morons.

Comment 12

[Roman Müller]

Perhaps it will get fixed.... few years later. Considering age of this bug.

Comment 13

[:Gijs (he/him)]

(In reply to Roman Müller from comment #11)
> With every single update on Nightly for last few weeks I'm finding [issues].

So file bugs.

> Few days ago you removed possibility to move refresh button around.

It wasn't possible in australis-themed Firefox without an add-on, but we'll be adding that possibility in Photon, actually.

> The fact how it [the bookmarks menu is] anchored is however very amusing.
> 
> http://fii.cz/xbuxtcph

Can't reproduce on either OS X or Windows 10. File a bug with more details if you can reproduce on a clean profile - without the abuse this time.

Comment 14

[Mike Hoye [:mhoye]]

Roman, I encourage you to read our Etiquette and Contributor Guidelines before continuing your participation in this or any other bug. If you can't find a way to communicate in Bugzilla without insulting or demeaning other contributors, don't. If you insist on doing so, my next step will be to lock your account.

Thank you, and have a good weekend.