Closed Bug 1206142 Opened 7 years ago Closed 7 years ago

Android 'mach xpcshell-test' fails with 'You must provide a device IP to connect to via the --ip option'


(Testing :: XPCShell Harness, defect)

Not set


(firefox43 fixed)

Tracking Status
firefox43 --- fixed


(Reporter: gbrown, Assigned: gbrown)



(1 file)

I think this regressed within the last 24 hours.

gbrown@mozpad:~/src$ ./mach xpcshell-test
From _tests: Kept 36386 existing; Added/updated 0; Removed 0 files and 0 directories.
Error running mach:


The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error

The details of the failure are as follows:

Exception: You must provide a device IP to connect to via the --ip option

  File "/home/gbrown/src/testing/xpcshell/", line 364, in run_xpcshell_test
    return xpcshell.run_test(**params)
  File "/home/gbrown/src/testing/xpcshell/", line 169, in run_test
  File "/home/gbrown/src/testing/xpcshell/", line 156, in get_devicemanager
    raise Exception("You must provide a device IP to connect to via the --ip option")
It looks like the default device manager changed from adb to sut. "mach xpcshell-test --dm_trans adb" is an effective work-around.
I think this was affected by bug 1193257. Previously, the harness --dm_trans default was sut but that was over-ridden by mach. Now mach and the harness use the default in xpcshellcommandline.
Android 2.3 mozharness jobs assume 'sut' is the default:

07:13:38     INFO - Running command: ['/builds/slave/test/build/venv/bin/python', '-u', '/builds/slave/test/build/tests/xpcshell/', '--deviceIP=', '--devicePort=20701', '--xre-path=/builds/slave/test/build/hostutils/xre', '--testing-modules-dir=/builds/slave/test/build/tests/modules', '--apk=/builds/slave/test/build/', '--no-logfiles', '--symbols-path=', '--manifest=tests/xpcshell.ini', '--log-raw=/builds/slave/test/build/blobber_upload_dir/xpcshell-3_raw.log', '--log-errorsummary=/builds/slave/test/build/blobber_upload_dir/xpcshell-3_errorsummary.log', '--total-chunks=3', '--this-chunk=3'] in /builds/slave/test/build/tests/xpcshell
Assignee: nobody → gbrown
This changes the xpcshellcommandline Android default dm_trans to adb. mach uses that, fixing this bug. 

To avoid changes to mozharness jobs, I explicitly specify sut for Android 2.3 and Android x86 (Android 4.3 uses adb and already explicitly selects adb).
Attachment #8663048 - Flags: review?(james)
Attachment #8663048 - Flags: review?(james) → review+
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.