1206174 - Improve code readability of FMRadioService

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Sotaro Ikeda [:sotaro]]

Recently, I checked FMRadioService code. It seems better to improve code readability. For example, it is not easy to understand which function is hal function.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch Part 1 - Remove implicit mozilla::hal namespace usage

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Use lambda

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 8663096 [details] [diff] [review]
patch part 2 - Use lambda

Review of attachment 8663096 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/fmradio/FMRadioService.cpp
@@ +752,5 @@
> +  NS_DispatchToMainThread(NS_NewRunnableFunction(
> +    [self] () -> void {
> +      self->NotifyFMRadioEvent(RDSEnabledChanged);
> +    }
> +  ));

This codes is called lots of times.
Maybe we can use the wrapper function, like DispatchRMRadioEventToMainThread(event).

@@ +776,5 @@
> +    NS_DispatchToMainThread(NS_NewRunnableFunction(
> +      [self] () -> void {
> +        self->NotifyFMRadioEvent(RDSEnabledChanged);
> +      }
> +    ));

Ditto.

@@ +991,5 @@
> +    NS_DispatchToMainThread(NS_NewRunnableFunction(
> +      [self] () -> void {
> +        self->NotifyFMRadioEvent(PIChanged);
> +      }
> +    ));

Ditto.

@@ +1006,5 @@
> +    NS_DispatchToMainThread(NS_NewRunnableFunction(
> +      [self] () -> void {
> +        self->NotifyFMRadioEvent(PTYChanged);
> +      }
> +    ));

Ditto.

@@ +1043,5 @@
> +        NS_DispatchToMainThread(NS_NewRunnableFunction(
> +          [self] () -> void {
> +            self->NotifyFMRadioEvent(PSChanged);
> +          }
> +        ));

Ditto.

@@ +1063,5 @@
> +        NS_DispatchToMainThread(NS_NewRunnableFunction(
> +          [self] () -> void {
> +            self->NotifyFMRadioEvent(RadiotextChanged);
> +          }
> +        ));

Ditto.

@@ +1109,5 @@
> +      NS_DispatchToMainThread(NS_NewRunnableFunction(
> +        [self] () -> void {
> +          self->NotifyFMRadioEvent(RadiotextChanged);
> +        }
> +      ));

Ditto.

@@ +1128,5 @@
> +        NS_DispatchToMainThread(NS_NewRunnableFunction(
> +          [self] () -> void {
> +            self->NotifyFMRadioEvent(RadiotextChanged);
> +          }
> +        ));

Ditto.

@@ +1169,5 @@
> +      NS_DispatchToMainThread(NS_NewRunnableFunction(
> +        [self] () -> void {
> +          self->NotifyFMRadioEvent(RadiotextChanged);
> +        }
> +      ));

Ditto.

@@ +1185,5 @@
> +      NS_DispatchToMainThread(NS_NewRunnableFunction(
> +        [self] () -> void {
> +          self->NotifyFMRadioEvent(PTYChanged);
> +        }
> +      ));

Ditto.

@@ +1213,5 @@
> +  NS_DispatchToMainThread(NS_NewRunnableFunction(
> +    [self] () -> void {
> +      self->NotifyFMRadioEvent(NewRDSGroup);
> +    }
> +  ));

Ditto.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Alastor Wu [:alwu] from comment #3)
> Comment on attachment 8663096 [details] [diff] [review]
> patch part 2 - Use lambda
> 
> Review of attachment 8663096 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/fmradio/FMRadioService.cpp
> @@ +752,5 @@
> > +  NS_DispatchToMainThread(NS_NewRunnableFunction(
> > +    [self] () -> void {
> > +      self->NotifyFMRadioEvent(RDSEnabledChanged);
> > +    }
> > +  ));
> 
> This codes is called lots of times.
> Maybe we can use the wrapper function, like
> DispatchRMRadioEventToMainThread(event).
> 

Yea, I'll update it.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Use lambda

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=35f5263bbb81

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd1f2144cd84

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd1f2144cd84