1206253 - [Dogfood] [WiFi] View network details and forget network

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Manel Rhaiem [:manel]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150918030202

Steps to reproduce:

General assignments at : https://docs.google.com/spreadsheets/d/1RNVZbWiqc4n4h0ftlzzdYJ-a7Iu0YZEQZUfMEOJj3Co/edit#gid=0 

#15898 Created by DerekH on 2015-02-27

Ensure the user can view all WiFi details for a connected network. Also ensure networks can be disconnected from and forgotten

Comment 1

[Martijn Wargers (dead)]

If you're planning on working on this, you should assign yourself to it.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mermi:bug1206253 > mozilla-b2g:master

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8663878 [details] [review]
[gaia] mermi:bug1206253 > mozilla-b2g:master

You should add this test to the manifest.ini file:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/manifest.ini
Add at least these to it: dogfood = true, wifi = true, online = true.

I also made some comments in the pull request.

Comment 4

[Manel Rhaiem [:manel]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #3)
> Comment on attachment 8663878 [details] [review]
> [gaia] mermi:bug1206253 > mozilla-b2g:master
> 
> You should add this test to the manifest.ini file:
> http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/
> functional/settings/manifest.ini
> Add at least these to it: dogfood = true, wifi = true, online = true.
> 
> I also made some comments in the pull request.

OK, thank you Martijin :)

Comment 5

[No-Jun Park [:njpark]]

Agree with Martijn's PR comments.  The key thing is that once you perform a key action of the script, you should explicitly verify the effects of the action.  So in this case, we should verify whether the wifi is really active, and whether it's really forgotten.

Comment 6

[No-Jun Park [:njpark]]

Comment on attachment 8663878 [details] [review]
[gaia] mermi:bug1206253 > mozilla-b2g:master

LGTM

Comment 7

[Martijn Wargers (dead)]

Comment on attachment 8663878 [details] [review]
[gaia] mermi:bug1206253 > mozilla-b2g:master

I made 2 comments that could be improved in the test, can you fix those? It looks good for the rest, thanks!

Comment 8

[Manel Rhaiem [:manel]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #7)
> Comment on attachment 8663878 [details] [review]
> [gaia] mermi:bug1206253 > mozilla-b2g:master
> 
> I made 2 comments that could be improved in the test, can you fix those? It
> looks good for the rest, thanks!

Done Martijin thnaks :)

Comment 9

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/4cd181ecc71dbae17aecc37d572911d53ecf8414

Thanks again!