1206280 - [Aries][Contacts] Last contact Image disappear when user shares contact with email

Status: RESOLVED DUPLICATE of bug 1203762

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[[:VladimirBelonenko]]

Attachment: logcat_20150918_1458.txt

Description:When you share contact  to Email and go back to contacts Notice last picture of contacts disappear.

Repro Steps:
1. launch contacts app
2. create a couple new contacts with pictures from gallery
3. click on contact and select Share Contact.
4. Select Email and press back arrow button twice.
5. Observe that last contacts image disappears.

Actual:
Sharing a contact with E-mail, you're contact image automatically disappears.
 
Expected:
When user shares a contact with E-mail, the contact should have an image.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150918122511
Gaia: 4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko: 37c7812ce0e6d10c7e7182f12e752832835e1d67
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro frequency: 3/3
See attached: Video and logcat

Comment 1

[[:VladimirBelonenko]]

This issue does not occur on 2.5 Flame
Result: When user shares a contact with E-mail, the contact image did not delete.

Environmental Variables:
Device: Flame 2.5 kk Full Flash (319 mb)
Build ID: 20150916030229
Gaia: 994ff1537c2d7ca4d1658806c50f3ceba1053f9b
Gecko: 3e8dde8f8c174cce2c0b65c951808f88e35d1875
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

=============================================================================================

This issue does not occur on 2.2 Flame
Result: When user shares a contact with E-mail, the contact image did not delete.

Environmental Variables:
Device: Flame 2.2 kk Full Flash (319 mb) 
BuildID: 20150918002506
Gaia: d52d714afd14c6253ddac8fab63f29b8bcf59f2b
Gecko: 3ee82451dd67
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

[Blocking Requested - why for this release]:

Data loss.

Comment 3

[Maria Angeles Oteo (:oteo)]

Francisco, could it be related to bug 1203762, that has been recently reopened?

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comms triage: Functional regression from 2.2, leading to dataloss

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1203945 seems to have caused this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Aries 2.5
BuildID: 20150917091507
Gaia: eb62d50351fd6a9b560fe369387d8138b9b3a2d3
Gecko: 5ef884a2b02234c54e64e3f2a1427b067dcdc732
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken 
Environmental Variables:
Device: Aries 2.5
BuildID: 20150917133824
Gaia: c06f2402e89923810bc47e2af3689660859999db
Gecko: 7941c5a6c7a6ccb70fe2ff9db4302d962d6172a4
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: eb62d50351fd6a9b560fe369387d8138b9b3a2d3
Gecko: 7941c5a6c7a6ccb70fe2ff9db4302d962d6172a4

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: c06f2402e89923810bc47e2af3689660859999db
Gecko: 5ef884a2b02234c54e64e3f2a1427b067dcdc732

Gecko Pushlog: https://github.com/mozilla-b2g/gaia/compare/eb62d50351fd6a9b560fe369387d8138b9b3a2d3...c06f2402e89923810bc47e2af3689660859999db

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Mentioned the wrong bug in previous comment.  This came with the reversion of parts of the NGA contacts.  Francisco is already ni? here.  Johan does anything in particular stand out as a cause here?

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

:oteo it should not be related, but will know more once we look at the code.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comms triage: Same conclusion as comment 4.

(In reply to Jayme Mercado [:JMercado] from comment #6)
> Johan does anything in particular stand out as a cause here?
Like you mentioned, this is a side effect of the reverts. A |git bisect| would highlight exactly which revert is the culprit. However, I wasn't able to repro with these gaias on top of [1]:
* Latest master 28f3b92cc23f3b0a0d95c111f182485283a1f006
* Latest commit in the window: c06f2402e89923810bc47e2af3689660859999db
* Some commits while doing a git bisect

I am not exactly sure I'm following the exact STR. Should some of the contact have the same image? Should I close the contact app once I created 4 contacts? Should they have phone numbers? 

[1] Build ID               20150927001555
Gaia Date              2015-09-17 10:13:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150926.233607
Firmware Date          Sat Sep 26 23:36:15 UTC 2015
Bootloader             s1

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Note: This issue is much easier to reproduce on Aries than Flame.

Pre-requisites:
Do not have an email account set up.

I used these steps:
1) Create 4 contacts with a name and picture (I used relatively large images for the picture which may have been related)
2) Select the top contact
3) Select Share > Email.
4) Quickly back out to the main contacts screen.

You should then see the last contact without an image.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

:oteo you were totally right, this is a duplicate of bug 1204829

Comment 11

[Maria Angeles Oteo (:oteo)]

I think this is the correct duplicated bug, correct me if I am wrong Francisco