1206308 - Minor enhancements to make-source-package.sh

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

I was working with someone on IRC to try out an esr38 source package, and fiddled around with the packaging command.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Minor enhancements to make-source-package.sh

Here are my changes. The zlib and nspr stuff are necessary, at least for it to work on Windows.

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 8663202 [details] [diff] [review]
Minor enhancements to make-source-package.sh

Review of attachment 8663202 [details] [diff] [review]:
-----------------------------------------------------------------

Great. Thanks for doing this!

Comment 3

[Sean Stangl [:sstangl]]

Comment on attachment 8663202 [details] [diff] [review]
Minor enhancements to make-source-package.sh

Review of attachment 8663202 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/make-source-package.sh
@@ +4,5 @@
>  # files we don't actually maintain ourselves, and requirements could easily be
>  # broken.
>  set -e
>  
> +MAKE=${MAKE:-make}

An alternate way that may be preferable, if you want:
: ${MAKE:=make}

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/047cd783c3e2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/047cd783c3e2