1206311 - [Music][NGA] Flash of incorrect album art in player view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Justin D'Arcangelo [:justindarc]]

When switching between songs, there is sometimes a flash of black or incorrect album art before the correct album art appears. This is a bug in the <music-artwork> web component.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1206311 > mozilla-b2g:master

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8663217 [details] [review]
[gaia] justindarc:bug1206311 > mozilla-b2g:master

squib: Simple patch that waits for the <img> tag to receive the 'load' event before swapping to the active image. This prevents a FOUAA (flash-of-unwanted-album-art) :-)

Comment 3

[Jim Porter (:squib)]

Comment on attachment 8663217 [details] [review]
[gaia] justindarc:bug1206311 > mozilla-b2g:master

r=me with comments addressed.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/68361828ae88dffd04b250121b5f2472a63f4bf0

Comment 5

[Verson Xiong (Leave from Mozilla)]

Attachment: FlameKK_v2.5.3gp

This bug has been verified as "pass" on NGA music app of FlameKK/Arieskk v2.5 latest build by STR in comment 0.
Actually result: When user switching between songs,the art album displayed normal and no flash happened.
Reproduce rate: 0/5
See attachment: FlameKK_v2.5.3gp

Device: Flame KK v2.5(Pass)
Build ID               20151008150210
Gaia Revision          e698df503ff700eb5782e3d50c6eb753567d3451
Gaia Date              2015-10-08 17:26:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e5f1bc63ad52d0eb86f7fb838226ca6036774660
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151008.182756
Firmware Date          Thu Oct  8 18:28:08 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master(Pass)
Build ID               20151008233852
Gaia Revision          e698df503ff700eb5782e3d50c6eb753567d3451
Gaia Date              2015-10-08 17:26:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/23b7f289df923c01e692299fcd4be7029de8b155
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151008.225742
Firmware Date          Thu Oct  8 22:57:51 UTC 2015
Bootloader             s1