Closed Bug 1206406 Opened 4 years ago Closed 4 years ago

Permaorange relations/test_embeds.xul | Assertion count 2 is greater than expected range 0-0 assertions when mozilla-central merges to aurora on September 21

Categories

(Toolkit :: Performance Monitoring, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

I don't understand how this could be, since the test appears to only open about:about and about:mozilla, but https://treeherder.mozilla.org/logviewer.html#?job_id=11666762&repo=try is permaorange on every OS on my central-as-aurora try push, with two "ASSERTION: nsAboutRedirector called for unknown case: 'Error'" assertions.

http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsAboutRedirector.cpp#86 appears to be the only nightly-only about: URL, http://mxr.mozilla.org/mozilla-central/search?find=%2Faccessible%2Ftests%2F&string=performance appears to say that no a11y test opens about:performance, but still, every debug m-oth is going to have this test failing because of two unexpected assertions.
Blocks: 1169209
Component: Disability Access APIs → Performance Monitoring
Product: Core → Toolkit
Attached patch fixSplinter Review
Ah, you have to also ifdef the CID, because about:about iterates through them to build the list.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #8663322 - Flags: review?(dteller)
Comment on attachment 8663322 [details] [diff] [review]
fix

Review of attachment 8663322 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #8663322 - Flags: review?(dteller) → review+
https://hg.mozilla.org/mozilla-central/rev/a4e440c29da9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.