Closed
Bug 1206421
Opened 10 years ago
Closed 9 years ago
Solve the curious case of JunQuilla junk % column non sorting, secondarily
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 45.0
People
(Reporter: alta88, Assigned: alta88)
Details
Attachments
(1 file, 1 obsolete file)
|
20.08 KB,
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
the original code always gets the primary sort custom column handler, potentially mixing up whether a string or int is to be used on the secondary sort.
Assignee: nobody → alta88
Attachment #8663319 -
Flags: review?(rkent)
also fix grouped view for int sorts.
Attachment #8663319 -
Attachment is obsolete: true
Attachment #8663319 -
Flags: review?(rkent)
Attachment #8663416 -
Flags: review?(rkent)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8663416 [details] [diff] [review]
custColSecondarySort.patch
Review of attachment 8663416 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry I got so far behind. I do appreciate the work you are doing to clean this up, but it is not easy code to review.
LGTM
Attachment #8663416 -
Flags: review?(rkent) → review+
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/0e68d7c33373a7bb32b219a6f83fe0779524f2b3
Bug 1206421 - Solve the curious case of JunQuilla junk % column non sorting, secondarily. r=rkent
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in
before you can comment on or make changes to this bug.
Description
•