1206426 - Update WebIDE's unrestricted help URL

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Oriol Brufau [:Oriol]]

See http://mxr.mozilla.org/mozilla-release/source/browser/devtools/webide/content/runtimedetails.js#13
> const UNRESTRICTED_HELP_URL = "https://developer.mozilla.org/docs/Tools/WebIDE#Unrestricted_app_debugging_%28including_certified_apps.2C_main_process.2C_etc.%29";

But the contents of that MDN article have changed. Now it should be
> const UNRESTRICTED_HELP_URL = "https://developer.mozilla.org/docs/Tools/WebIDE/Running_and_debugging_apps#Unrestricted_app_debugging_%28including_certified_apps_main_process_etc.%29";

Comment 1

[Manav Batra]

Hi,

I'd like to try my hand at this bug.
Could you point me to the repo I need to clone for this?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Take a look at our hacking[1] page to get started, it contains all that and more.  

Comment 0 above mentions the file to modify, but it's since been moved to devtools/client/webide/content/runtimedetails.js.

Be sure to use the needinfo? field (set to "mentor") for future questions to make sure I don't miss them.

If you come up with a patch, attach it here and set either feedback? if unsure or review? if you think it's done set to me when you're ready.

Thanks for looking into this!

[1]: https://wiki.mozilla.org/DevTools/Hacking

Comment 3

[Manav Batra]

Attachment: Updated WebIDE's unrestricted help URL

The DevTools Hacking link was really helpful, thanks!

I've made the recommended changes in this patch. I thinks it's ready for review.

Thanks!

Comment 4

[Manav Batra]

Also, could you assign the bug to me?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8669413 [details] [diff] [review]
Updated WebIDE's unrestricted help URL

Review of attachment 8669413 [details] [diff] [review]:
-----------------------------------------------------------------

Great, this change seems correct to me!

Can you update your patch to include "r=jryans" at the end of the commit message?  See this[1] for an example.

[1]: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Creating_a_patch_to_check_in

Comment 6

[Manav Batra]

Attachment: Updated WebIDE's unrestricted help URL

Missed that earlier, sorry.

Please find the updated patch attached.

Also, any specific time I can find you online on IRC?

Thanks.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Manav Batra from comment #6)
> Also, any specific time I can find you online on IRC?

I am in the US Central time zone (UTC -6 / -5).

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8669800 [details] [diff] [review]
Updated WebIDE's unrestricted help URL

Review of attachment 8669800 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!  I don't believe there are any tests to run for this case, so I'll land the patch for you in a moment.

Thank you for working on this!  Feel to check out other mentored bugs: http://firefox-dev.tools/

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a5abfa8e6310

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This bug will be marked FIXED once a sheriff merges the change into mozilla-central.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a5abfa8e6310

Comment 12

[alex_mayorga]

¡Hola Manav!

http://mxr.mozilla.org/mozilla-central/source/devtools/client/webide/content/runtimedetails.js#13 looks fine now.

¡Gracias!
Alex