Closed Bug 1206444 Opened 6 years ago Closed 6 years ago

Indent Return receipts options in account manager

Categories

(MailNews Core :: Account Manager, defect)

defect
Not set
trivial

Tracking

(firefox43 affected)

RESOLVED FIXED
Thunderbird 45.0
Tracking Status
firefox43 --- affected

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file, 1 obsolete file)

5.94 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
In the "Return receipts" pane of the account settings all the options are mashed together. The same set of options in Preferences->Advanced->General->Return receipts is nicely indented and separated. I propose to align the options in the AM in the same way.
Attached patch patch (obsolete) — Splinter Review
Attachment #8663342 - Flags: ui-review?(richard.marti)
Comment on attachment 8663342 [details] [diff] [review]
patch

Yes, this makes the appearance consistent.

Because you're touching mailnews code, does SM also indent the same? Only to be also consistent with SM.
Attachment #8663342 - Flags: ui-review?(richard.marti) → ui-review+
Attached patch patch v2Splinter Review
Thanks, good catch. Yes, Seamonkey has their own version of preferences and uses the same old design. I think the new spacing/indenting is more readable so let's try to convert also Seamonkey.
Attachment #8663342 - Attachment is obsolete: true
Attachment #8663393 - Flags: review?(iann_bugzilla)
Attachment #8663393 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Comment on attachment 8663393 [details] [diff] [review]
patch v2

a=Ratty for SeaMonkey CLOSED TREE
https://hg.mozilla.org/comm-central/rev/faf62f115efe
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in before you can comment on or make changes to this bug.