1206468 - Remove unused internal appearance value -moz-mac-unified-toolbar

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

So all uses of -moz-mac-unified-toolbar have been removed from our codebase since long ago (bug 534170). We should remove the value itself, shouldn't we?

Comment 1

[Stefan [:stefanh]]

If we remove it we should also remove it from the mdn documentation.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1206468 - Remove unused internal appearance value -moz-mac-unified-toolbar.

Bug 1206468 - Remove unused internal appearance value -moz-mac-unified-toolbar.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8677891 [details]
MozReview Request: Bug 1206468 - Remove unused internal appearance value -moz-mac-unified-toolbar.

Bug 1206468 - Remove unused internal appearance value -moz-mac-unified-toolbar.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8677891 [details]
MozReview Request: Bug 1206468 - Remove unused internal appearance value -moz-mac-unified-toolbar.

https://reviewboard.mozilla.org/r/23041/#review20555

Thanks!

::: widget/cocoa/nsCocoaWindow.mm:3297
(Diff revision 1)
> -//    will contain an entry for the widget type NS_THEME_TOOLBAR or
> +//    will contain an entry for the widget type NS_THEME_TOOLBAR or.

trailing "or."

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/798a61cdcf78b39e27238650aca8197bfef8a6b9
Bug 1206468 - Remove unused internal appearance value -moz-mac-unified-toolbar. r=mstange

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/798a61cdcf78

Comment 7

[Jean-Yves Perrier [:teoli]]

There was no mention of it on https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance
So I only updated: https://developer.mozilla.org/en-US/Firefox/Releases/44#CSS