1206491 - Fix a JavaScript error while about:cache opened and no incoming parameters

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[YF (Yang)]

Attachment: patch v1

STR:
Open about:cache and see Web Console.


TypeError: context is null aboutCache.js:13:5

No other abnormalities. Just eliminate an error.

Comment 1

[Honza Bambas (:mayhemer)]

Comment on attachment 8663391 [details] [diff] [review]
patch v1

Review of attachment 8663391 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/aboutcache/content/aboutCache.js
@@ +10,5 @@
>  var context = searchParams.get('context');
>  
>  // The context is in a format as used by the HTTP cache v2 back end
> +if (context)
> +  var [context, isAnon, isInBrowser, appId, isPrivate] = context.match(/(a,)?(b,)?(i\d+,)?(p,)?/);

better is:

var [context, isAnon, isInBrowser, appId, isPrivate] = (context ? context.match(/(a,)?(b,)?(i\d+,)?(p,)?/) : [null, false, false, null, false];

Comment 2

[Honza Bambas (:mayhemer)]

* false]);

Comment 3

[YF (Yang)]

(In reply to Honza Bambas (not reviewing) (:mayhemer) from comment #1)
> Comment on attachment 8663391 [details] [diff] [review]
> patch v1
> 
> Review of attachment 8663391 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/components/aboutcache/content/aboutCache.js
> @@ +10,5 @@
> >  var context = searchParams.get('context');
> >  
> >  // The context is in a format as used by the HTTP cache v2 back end
> > +if (context)
> > +  var [context, isAnon, isInBrowser, appId, isPrivate] = context.match(/(a,)?(b,)?(i\d+,)?(p,)?/);
> 
> better is:
> 
> var [context, isAnon, isInBrowser, appId, isPrivate] = (context ?
> context.match(/(a,)?(b,)?(i\d+,)?(p,)?/) : [null, false, false, null, false];

var [context, isAnon, isInBrowser, appId, isPrivate] = (context ? 
  context.match(/(a,)?(b,)?(i\d+,)?(p,)?/) : [null, false, false, null, false]);

Like this?

I don't see the necessity, and this increases the complexity, why we need it?

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 8663391 [details] [diff] [review]
patch v1

Hmm.. we are probably ok with the variables at the default 'undefined' value.  OK then.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b9e4e20ce06

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6b9e4e20ce06