Closed Bug 1206520 Opened 5 years ago Closed 4 years ago
Add a pref that makes asm
.js validation failure throw an error?
Sounds fine to me
This adds an option to throw on validation failures (preconditions errors (e.g. the asm.js module function is a generator) and actual validation failures). Note that it only applies to validation failures, not link failures or directive failures (which are handled in several other places). The suggested name is a bit long ("throw_on_asmjs_validation_failure"), but I didn't see how to make it shorter without making it less explicit.
Assignee: nobody → benj
Status: NEW → ASSIGNED
Attachment #8666640 - Flags: review?(luke)
This creates a boolean pref for enabling "throw_on_asmjs_validation_failure", which is specified in the previous comment and implemented in the first patch.
Attachment #8666651 - Flags: review?(bzbarsky)
Comment on attachment 8666640 [details] [diff] [review] 1.throw_on_asmjs_validation_failure.patch Review of attachment 8666640 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8666640 - Flags: review?(luke) → review+
werror could do whatever it wants, since nothing really defines when the JS engine will do a warning. It's particularly bad in "strict warnings" mode....
Comment on attachment 8666651 [details] [diff] [review] 2.add.about-config.prefs.patch You need to add this to all.js to have it show up in about:config, right? r=me with that
Attachment #8666651 - Flags: review?(bzbarsky) → review+
Thanks for doing this :bbouvier! Integrated the feature to emrun at https://github.com/juj/emrun/commit/ca9aa1767cb60d9e717ff5574b09c556ecfbe83e and Emscripten unit test suites at http://clb.demon.fi:8112/waterfall .
You need to log in before you can comment on or make changes to this bug.