FFmpeg MediaDataDecoder not accessing this codec context in a thread safe manner

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

43 Branch
mozilla44
Points:
---

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
This is similar to bug 1192675.

Must ensure the mCodecContext is only ever accessed on the same thread to prevent races.
(Assignee)

Comment 1

4 years ago
Add strong assertion that it is indeed the case.
Attachment #8663502 - Flags: review?(cpearce)
(Assignee)

Updated

4 years ago
Assignee: nobody → jyavenard
(Assignee)

Comment 2

4 years ago
Make it consistent across the use of virtual/override
Attachment #8663503 - Flags: review?(cpearce)
Attachment #8663502 - Flags: review?(cpearce) → review+
Comment on attachment 8663503 [details] [diff] [review]
P2. Clean up header declarations.

Review of attachment 8663503 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/android/AndroidDecoderModule.h
@@ +55,5 @@
> +  nsRefPtr<MediaDataDecoder::InitPromise> Init() override;
> +  nsresult Flush() override;
> +  nsresult Drain() override;
> +  nsresult Shutdown() override;
> +  nsresult Input(MediaRawData* aSample);

nsresult Input(MediaRawData* aSample) override;

?
Attachment #8663503 - Flags: review?(cpearce) → review+
(Assignee)

Updated

4 years ago
Duplicate of this bug: 1206567
https://hg.mozilla.org/mozilla-central/rev/aa240de37603
https://hg.mozilla.org/mozilla-central/rev/f72556c17c7c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(Assignee)

Updated

4 years ago
Blocks: 1214943
(Assignee)

Comment 7

4 years ago
Comment on attachment 8663502 [details] [diff] [review]
P1. Ensure FFmpeg decoder is only accessed through the decoder's task queue.

Approval Request Comment
[Feature/regressing bug #]: This is ensuring our FFmpeg support is robust
[User impact if declined]: unsafe use of FFmpeg, crashes, likely security risk
[Describe test coverage new/current, TreeHerder]: In central for several weeks.
[Risks and why]: Low
[String/UUID change made/needed]: None
Attachment #8663502 - Flags: approval-mozilla-aurora?
Comment on attachment 8663502 [details] [diff] [review]
P1. Ensure FFmpeg decoder is only accessed through the decoder's task queue.

Approved for uplift; see bug 1214943.
jya will land this.
Attachment #8663502 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

3 years ago
See Also: → 1240411
You need to log in before you can comment on or make changes to this bug.