1206568 - FFmpeg MediaDataDecoder not accessing this codec context in a thread safe manner

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

This is similar to bug 1192675.

Must ensure the mCodecContext is only ever accessed on the same thread to prevent races.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: P1. Ensure FFmpeg decoder is only accessed through the decoder's task queue.

Add strong assertion that it is indeed the case.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: P2. Clean up header declarations.

Make it consistent across the use of virtual/override

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8663503 [details] [diff] [review]
P2. Clean up header declarations.

Review of attachment 8663503 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/android/AndroidDecoderModule.h
@@ +55,5 @@
> +  nsRefPtr<MediaDataDecoder::InitPromise> Init() override;
> +  nsresult Flush() override;
> +  nsresult Drain() override;
> +  nsresult Shutdown() override;
> +  nsresult Input(MediaRawData* aSample);

nsresult Input(MediaRawData* aSample) override;

?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa240de37603
https://hg.mozilla.org/integration/mozilla-inbound/rev/f72556c17c7c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aa240de37603
https://hg.mozilla.org/mozilla-central/rev/f72556c17c7c

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8663502 [details] [diff] [review]
P1. Ensure FFmpeg decoder is only accessed through the decoder's task queue.

Approval Request Comment
[Feature/regressing bug #]: This is ensuring our FFmpeg support is robust
[User impact if declined]: unsafe use of FFmpeg, crashes, likely security risk
[Describe test coverage new/current, TreeHerder]: In central for several weeks.
[Risks and why]: Low
[String/UUID change made/needed]: None

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8663502 [details] [diff] [review]
P1. Ensure FFmpeg decoder is only accessed through the decoder's task queue.

Approved for uplift; see bug 1214943.
jya will land this.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/26262d256546