Closed Bug 1206595 Opened 4 years ago Closed 4 years ago

Port relevant changes from | bug 885982 - Move MozTCPSocket and MozTCPServerSocket to WebIDL | to Thunderbird

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(thunderbird43 fixed, thunderbird44 fixed)

RESOLVED FIXED
Thunderbird 44.0
Tracking Status
thunderbird43 --- fixed
thunderbird44 --- fixed

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1206592 +++

Currently we're busted because of bug 885982.  Need to port the
relevant changes.
Attachment #8663511 - Flags: review?(Pidgeot18)
Comment on attachment 8663511 [details] [diff] [review]
proposed patch(v1)

Review of attachment 8663511 [details] [diff] [review]:
-----------------------------------------------------------------

What about suite/ and im/ ? r=philipp with the same changes applied there.
Attachment #8663511 - Flags: review?(Pidgeot18) → review+
Blocks: 1206609
Suite and IM have their own bugs, already landed.
I'll land this shortly.
Yes please, this makes the builds work again, I have tested it on try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9ff44b0680d9
https://hg.mozilla.org/comm-central/rev/8c5af006b91c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 44.0
Required for comm-aurora too.
Comment on attachment 8663511 [details] [diff] [review]
proposed patch(v1)

[Approval Request Comment]
Regression caused by (bug #): 885982
User impact if declined: make pkg fails.
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): none.
Attachment #8663511 - Flags: approval-comm-aurora?
Comment on attachment 8663511 [details] [diff] [review]
proposed patch(v1)

a+ for aurora, also for the other products if you haven't already gotten it.
Attachment #8663511 - Flags: approval-comm-aurora? → approval-comm-aurora+
Keywords: checkin-needed
Whiteboard: [checkin-needed comm-aurora]
You need to log in before you can comment on or make changes to this bug.