1206595 - Port relevant changes from | bug 885982 - Move MozTCPSocket and MozTCPServerSocket to WebIDL | to Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

+++ This bug was initially created as a clone of Bug #1206592 +++

Currently we're busted because of bug 885982.  Need to port the
relevant changes.

Comment 1

[Edmund Wong (:ewong)]

Attachment: proposed patch(v1)

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8663511 [details] [diff] [review]
proposed patch(v1)

Review of attachment 8663511 [details] [diff] [review]:
-----------------------------------------------------------------

What about suite/ and im/ ? r=philipp with the same changes applied there.

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23970
repository: comm-central
start_time: 2015-09-20T13:43:18
who: ewong[at]pw-wspx[dot]org
machine: bld-lion-r5-079
buildname: TB OS X 10.7 comm-central build
revision: 32e405315e3e

OSError: [Errno 2] No such file or directory: '/builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/objdir-tb'
make[3]: *** [make-package-internal] Error 255
make[2]: *** [make-package] Error 2
make[1]: *** [default] Error 2
make: *** [package] Error 2

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23969
repository: comm-central
start_time: 2015-09-20T13:43:19
who: ewong[at]pw-wspx[dot]org
machine: bld-lion-r5-066
buildname: TB OS X 10.7 64-bit comm-central leak test build
revision: 32e405315e3e

CalledProcessError: Command '['hg', 'log', '-r', u'32e405315e3e404ce6bb17768737b21887ba9db3', '--template', '{node}']' returned non-zero exit status 255
"%s: 0x%p FATAL ERROR\n", logname, lr, 0 );
Assertion failure: IsOnBackgroundThread(), at /builds/slave/tb-c-cen-m64-d-000000000000000/build/mozilla/ipc/glue/BackgroundImpl.cpp:199
make[3]: *** [stage-package] Error 1
make[2]: *** [make-package] Error 2
make[1]: *** [default] Error 2
make: *** [package] Error 2

Comment 5

[:aceman]

Suite and IM have their own bugs, already landed.

Comment 6

[Magnus Melin [:mkmelin]]

I'll land this shortly.

Comment 7

[:aceman]

Yes please, this makes the builds work again, I have tested it on try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9ff44b0680d9

Comment 8

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/8c5af006b91c

Comment 9

[Stefan Sitter [:ssitter]]

Required for comm-aurora too.

Comment 10

[Edmund Wong (:ewong)]

Comment on attachment 8663511 [details] [diff] [review]
proposed patch(v1)

[Approval Request Comment]
Regression caused by (bug #): 885982
User impact if declined: make pkg fails.
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): none.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8663511 [details] [diff] [review]
proposed patch(v1)

a+ for aurora, also for the other products if you haven't already gotten it.

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/releases/comm-aurora/rev/d0ddaf043bbc