1206605 - Back out bug 1160447 (internalErrorCode debug code for Netflix XHR error)

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

+++ This bug was initially created as a clone of Bug #1196818 +++

Back out diagnostic patch from bug 1160447 comment 42 before releasing Firefox 42.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Kyle, are you going to take care of this patch?

Tracking as we don't want to ship with this diag crash.

Comment 2

[Chris Peterson [:cpeterson]]

Sylvestre, I can back out this patch when the time comes. Is backing out in 42.0b8 early enough for you?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Sure! Thanks

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Chris, could you prepare the patch, have the r+ and fill the uplift request? I won't have to bother you after that :)

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: backout-3364de1b17d6.patch

Back out XHR internalErrorCode debug code added for Netflix test.

Comment 6

[Chris Peterson [:cpeterson]]

Comment on attachment 8672039 [details] [diff] [review]
backout-3364de1b17d6.patch

Approval Request Comment
[Feature/regressing bug #]: XHR internalErrorCode landed in bug 1160447
[User impact if declined]: We will ship debug code that is accessible by web content to the release channel.
[Describe test coverage new/current, TreeHerder]: This code has landed and been backed out before. :)
[Risks and why]: Low risk. This debug code only exists in Beta 42.
[String/UUID change made/needed]: None

Comment 7

[Chris Peterson [:cpeterson]]

We can remove internalErrorCode from Beta 42 at any time. This debug code is no longer useful for Netflix's testing because we now know it always returns error code 0 (which is not particularly useful) for the XHR problem Netflix is seeing.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8672039 [details] [diff] [review]
backout-3364de1b17d6.patch

OK, thanks. Let's take it now then. Should be in 42 beta 7.

Comment 9

[Carsten Book [:Tomcat]]

landed in https://hg.mozilla.org/releases/mozilla-beta/rev/124a1bf2bdfb

Comment 10

[Chris Peterson [:cpeterson]]

Resolving this bug as fixed because the backout patch landed on beta. It doesn't need to land on central.