Closed Bug 1206615 Opened 5 years ago Closed 5 years ago

Add Kinto.js into the Sync app

Categories

(Firefox OS Graveyard :: Sync, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S8 (02Oct)

People

(Reporter: mbdejong, Assigned: mbdejong)

References

Details

Attachments

(1 file)

We need to add Kinto.js into the Sync app. I'm waiting for Kinto.js 1.0 to be tagged [1], but if that's not during this sprint then we can just build Kinto.js from its latest master.

[1] https://github.com/Kinto/kinto.js/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.0.0
Assignee: nobody → mbdejong
Blocks: 1195647
Target Milestone: --- → FxOS-S8 (02Oct)
Version 1.0 of Kinto.js is expected before the end of Q3. There are a few API changes to be addressed in SyncEngine, will make that part of this bug.
API changes will be dealt with in bug 1206473
Attachment #8667843 - Flags: review?(ferjmoreno)
Blocks: 1206473
Comment on attachment 8667843 [details] [review]
[gaia] michielbdejong:1206615-add-kinto-js > mozilla-b2g:master

Shouldn't we use the minified version? Or maybe have both and use the minified on production builds?
Attachment #8667843 - Flags: review?(ferjmoreno)
Flags: needinfo?(mbdejong)
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #4)
> Comment on attachment 8667843 [details] [review]
> [gaia] michielbdejong:1206615-add-kinto-js > mozilla-b2g:master
> 
> Shouldn't we use the minified version? Or maybe have both and use the
> minified on production builds?

OK! Done.
Flags: needinfo?(mbdejong)
Comment on attachment 8667843 [details] [review]
[gaia] michielbdejong:1206615-add-kinto-js > mozilla-b2g:master

Thanks
Attachment #8667843 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/707c8ee277e0522c281b3d0de4e4b1d40a7d3e8d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.