1206722 - test_video_playback.py TestVideoPlayback.test_video_playback_partial raises TimeoutException although video has reached expected duration

Status: RESOLVED WONTFIX

(Testing Graveyard :: external-media-tests, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

First encountered in https://treeherder.mozilla.org//logviewer.html#?job_id=1186676&repo=mozilla-aurora

>>    ERROR -  TEST-UNEXPECTED-ERROR | test_video_playback.py TestVideoPlayback.test_video_playback_partial | TimeoutException: Traceback (most recent call last):
>>     INFO -    File "c:\jenkins\workspace\mn-mse-youtube-default-aurora-win7_32_64\firefox_media_tests\utils.py", line 32, in verbose_until
>>     INFO -      return wait.until(condition)
>>     INFO -    File "c:\jenkins\workspace\mn-mse-youtube-default-aurora-win7_32_64\build\venv\lib\site-packages\marionette_driver\wait.py", line 143, in until
>>     INFO -      cause=last_exc)
>>    ERROR -  TimeoutException: Timed out after 89.2 seconds
>>     INFO -  VideoPuppeteer - test url: https://www.youtube.com/watch?v=rjmuKV9BTkE: {
>>     INFO -      (video)
>>     INFO -      current_time: 88.49068,
>>     INFO -      duration: 88.49068,
>>     INFO -      expected_duration: 60.626475,
>>     INFO -      lag: 1.48024094215,
>>     INFO -      url: https://www.youtube.com/watch?v=rjmuKV9BTkE
>>     INFO -      src: mediasource:https://www.youtube.com/389c1e0a-39fa-44f0-bd08-0726e9989a8f
>>     INFO -      frames total: 2120
>>     INFO -       - dropped: 0
>>     INFO -       - corrupted: 0
>>    ERROR -  }, caused by <class 'marionette_driver.errors.TimeoutException'>
>>     INFO -  Traceback (most recent call last):
>>     INFO -    File "c:\jenkins\workspace\mn-mse-youtube-default-aurora-win7_32_64\build\venv\lib\site-packages\marionette\marionette_test.py", line 296, in run
>>     INFO -      testMethod()
>>     INFO -    File "c:\jenkins\workspace\mn-mse-youtube-default-aurora-win7_32_64\firefox_media_tests\playback\test_video_playback.py", line 45, in test_video_playback_partial
>>     INFO -      self.run_playback(video)
>>     INFO -    File "c:\jenkins\workspace\mn-mse-youtube-default-aurora-win7_32_64\media_test_harness\testcase.py", line 48, in run_playback
>>     INFO -      video, playback_done)
>>     INFO -    File "c:\jenkins\workspace\mn-mse-youtube-default-aurora-win7_32_64\firefox_media_tests\utils.py", line 35, in verbose_until
>>    ERROR -      raise TimeoutException(message=message, cause=exc_info())
>>     INFO -  TEST-INFO took 181504ms

The issue is probably in |video_puppeteer.playback_done|:
>> if abs(remaining_time) < video.interval:

If video current_time exceeds expected_duration set by test_video_playback_partial, I think the test should still pass; that, or make the condition more generous e.g. video.interval * 2.

Comment 1

[Nagma Kapoor (:nagma)]

Hi! this seems like a bug I can work on. Is anyone assigned to it or could I give it a go?

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Hey Nagma, feel free to give it a shot and comment about your progress in the bug. Best people to talk to on IRC are sydpolk and me. I'm away until Friday. There is documentation on "external-media-tests" on MDN, which might help you get started.

If you post a bug comment that is a question, it's best to check the "Need more information from __" box at the bottom so that the right person is notified.

Comment 3

[Nagma Kapoor (:nagma)]

Hi Maja, thanks! I'll start working on it now and send updates on it as I'm going along.

Comment 4

[Nagma Kapoor (:nagma)]

Currently having some trouble with my IRC chat so I'm asking here instead. 

I ran ./mach external-media-tests before updating my local files and it was functioning fine. But then I did hg pull central; hg up central to get to the latest code. Now, running ./mach external-media-tests gives me an IOError: http://pastebin.com/MLtjjdM3 am I missing something here?

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Did you run |./mach build| after |hg up central|? Maybe your old build is broken. (Aside: to make building faster, you can edit your mozconfig file to enable Artifact Builds - https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds#Artifact_builds)

Otherwise, your error message tells me that Firefox crashed at start-up. If that keeps happening, it might make sense for you to report a new bug, but talk to us on IRC first.

Comment 6

[Nagma Kapoor (:nagma)]

Oh you're right, my build was broken. I fixed that, so the tests are working now. Thanks.

Comment 7

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

The media tests have been refactored such that this work is not needed any more.