Closed
Bug 120675
Opened 23 years ago
Closed 23 years ago
static win32 builds busted in activex & npsimple
Categories
(SeaMonkey :: Build Config, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.8
People
(Reporter: netscape, Assigned: netscape)
Details
Attachments
(1 file)
|
2.26 KB,
patch
|
bryner
:
review+
waterson
:
superreview+
|
Details | Diff | Splinter Review |
At peterl's request, we stopped installing the npsimple plugin sample into $(DIST) but somehow, it keeps getting added to the final-link lists. The activex control apparently has a dependency upon gkgfx.
| Assignee | ||
Comment 1•23 years ago
|
||
Oh, while working on the gmake win32 static build, I also noticed that the win32 nmake static builds only statically link in the components while the unix static builds link everything statically except xpcom, nspr & ldap. Do we have any plans to sync those differences or should I just force the non-component libraries to always be dynamic for win32?
Priority: -- → P2
Target Milestone: --- → mozilla0.9.8
| Assignee | ||
Comment 2•23 years ago
|
||
Comment 3•23 years ago
|
||
Comment on attachment 65528 [details] [diff] [review] Add gfx to activex, set bogus meta component for npsimple & remove link lists at start of export phase r=bryner, but remove the "echo foo" line
Attachment #65528 -
Flags: review+
Comment 4•23 years ago
|
||
Won't adding those $(RM) lines to `export' force a the meta module relink, everytime? I guess it's not that big of a deal (do we do the same thing on Unix?) The rest looks fine, sr=waterson.
Updated•23 years ago
|
Attachment #65528 -
Flags: superreview+
| Assignee | ||
Comment 5•23 years ago
|
||
Right, we do the same thing on unix. It's the only way of handling the case of libraries being removed from the final-link lists in a depend build.
| Assignee | ||
Comment 7•23 years ago
|
||
Patch checked in.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•