Mozilla-beta fails to build: variable 'reentrantFlag' set but not use

RESOLVED FIXED

Status

()

defect
--
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sylvestre, Assigned: mcmanus)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox42 fixed, firefox43 fixed, firefox44 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
/builds/slave/m-beta-lx-00000000000000000000/build/netwerk/protocol/http/nsHttpTransaction.cpp:769:17: error: variable 'reentrantFlag' set but not used [-Werror=unused-but-set-variable] 

This is blocking the build of 42beta1.
(Reporter)

Updated

4 years ago
Summary: Mozilla-beta fails to build → Mozilla-beta fails to build: variable 'reentrantFlag' set but not use
(Reporter)

Comment 1

4 years ago
Guys, can you help? Thanks
Flags: needinfo?(mcmanus)
Flags: needinfo?(daniel)
(Reporter)

Comment 2

4 years ago
Once a patch is r+, please consider that you have a blanket approval to land that directly into m-b.
The patch should be trivial.
(Assignee)

Comment 3

4 years ago
heh - the compiler figured out that's eval'd debug only in beta even though it has four state changes.

I'll add a LOG statement with it - that will chill out the compiler without changing behavior.
(Assignee)

Comment 4

4 years ago
bug 1206771 - fix reentrantFlag compiler warning on >= beta r=mayhemer
Attachment #8663754 - Flags: review?(jduell.mcbugs)
(Assignee)

Updated

4 years ago
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED

Updated

4 years ago
Attachment #8663754 - Flags: review?(jduell.mcbugs) → review+
(Assignee)

Comment 5

4 years ago
my plan is to land this after I have an opt build finish to confirm the issue.. but if someone is itchier than that, go ahead and steal it.
Flags: needinfo?(mcmanus)
(Assignee)

Comment 6

4 years ago
my clang doesn't figure out there is an error there, so I can't confirm the bug. Will just push and let treeherder decide I guess.
(Assignee)

Updated

4 years ago
Flags: needinfo?(daniel)
(Assignee)

Comment 8

4 years ago
I was able to confirm and verify with g++ on linux64
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 11

4 years ago
Thanks for the quick reaction, this is appreciated :)
You need to log in before you can comment on or make changes to this bug.