Closed Bug 1206771 Opened 5 years ago Closed 5 years ago
Mozilla-beta fails to build: variable 'reentrant
Flag' set but not use
/builds/slave/m-beta-lx-00000000000000000000/build/netwerk/protocol/http/nsHttpTransaction.cpp:769:17: error: variable 'reentrantFlag' set but not used [-Werror=unused-but-set-variable] This is blocking the build of 42beta1.
Summary: Mozilla-beta fails to build → Mozilla-beta fails to build: variable 'reentrantFlag' set but not use
Guys, can you help? Thanks
Once a patch is r+, please consider that you have a blanket approval to land that directly into m-b. The patch should be trivial.
heh - the compiler figured out that's eval'd debug only in beta even though it has four state changes. I'll add a LOG statement with it - that will chill out the compiler without changing behavior.
bug 1206771 - fix reentrantFlag compiler warning on >= beta r=mayhemer
Attachment #8663754 - Flags: review?(jduell.mcbugs)
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
my plan is to land this after I have an opt build finish to confirm the issue.. but if someone is itchier than that, go ahead and steal it.
my clang doesn't figure out there is an error there, so I can't confirm the bug. Will just push and let treeherder decide I guess.
I was able to confirm and verify with g++ on linux64
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d1dd289275ebc26d011bba21975a8682f5134ab bug 1206771 - fix reentrantFlag compiler warning on >= beta r=jduell
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Thanks for the quick reaction, this is appreciated :)
You need to log in before you can comment on or make changes to this bug.