Closed
Bug 1206771
Opened 9 years ago
Closed 9 years ago
Mozilla-beta fails to build: variable 'reentrantFlag' set but not use
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: Sylvestre, Assigned: mcmanus)
Details
Attachments
(1 file)
1.26 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
/builds/slave/m-beta-lx-00000000000000000000/build/netwerk/protocol/http/nsHttpTransaction.cpp:769:17: error: variable 'reentrantFlag' set but not used [-Werror=unused-but-set-variable] This is blocking the build of 42beta1.
Reporter | ||
Updated•9 years ago
|
Summary: Mozilla-beta fails to build → Mozilla-beta fails to build: variable 'reentrantFlag' set but not use
Reporter | ||
Comment 1•9 years ago
|
||
Guys, can you help? Thanks
Flags: needinfo?(mcmanus)
Flags: needinfo?(daniel)
Reporter | ||
Comment 2•9 years ago
|
||
Once a patch is r+, please consider that you have a blanket approval to land that directly into m-b. The patch should be trivial.
Assignee | ||
Comment 3•9 years ago
|
||
heh - the compiler figured out that's eval'd debug only in beta even though it has four state changes. I'll add a LOG statement with it - that will chill out the compiler without changing behavior.
Assignee | ||
Comment 4•9 years ago
|
||
bug 1206771 - fix reentrantFlag compiler warning on >= beta r=mayhemer
Attachment #8663754 -
Flags: review?(jduell.mcbugs)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Updated•9 years ago
|
Attachment #8663754 -
Flags: review?(jduell.mcbugs) → review+
Assignee | ||
Comment 5•9 years ago
|
||
my plan is to land this after I have an opt build finish to confirm the issue.. but if someone is itchier than that, go ahead and steal it.
Flags: needinfo?(mcmanus)
Assignee | ||
Comment 6•9 years ago
|
||
my clang doesn't figure out there is an error there, so I can't confirm the bug. Will just push and let treeherder decide I guess.
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/62eace42cee0
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(daniel)
Assignee | ||
Comment 8•9 years ago
|
||
I was able to confirm and verify with g++ on linux64
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d1dd289275ebc26d011bba21975a8682f5134ab bug 1206771 - fix reentrantFlag compiler warning on >= beta r=jduell
Assignee | ||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/15c5205c623f
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•9 years ago
|
||
Thanks for the quick reaction, this is appreciated :)
You need to log in
before you can comment on or make changes to this bug.
Description
•