Closed Bug 1206801 Opened 4 years ago Closed 4 years ago

fix broken CONFIG['DEBUG'] checks in moz.build files

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox43 fixed, firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

These were supposed to be CONFIG['MOZ_DEBUG'].  webapprt doesn't use the
define it set up, however, so it was deleted rather than fixed.
Credit to philor for pointing this out on IRC.
Attachment #8663779 - Flags: review?(mshal)
I pushed a slightly more conservative version of this patch to mozilla-beta to fix the build bustage there:

https://hg.mozilla.org/releases/mozilla-beta/rev/a91c7eca5508

I guess we'll need aurora uplift on this patch so aurora doesn't break on the next uplift to beta...
Comment on attachment 8663779 [details] [diff] [review]
fix broken CONFIG['DEBUG'] checks in moz.build files

>These were supposed to be CONFIG['MOZ_DEBUG'].  webapprt doesn't use the
>define it set up, however, so it was deleted rather than fixed.
>
>diff --git a/webapprt/win/moz.build b/webapprt/win/moz.build

Looks like you could also do webapprt/moz.build since it has a DEFINES['MOZ_DEBUG'] that seems unnecessary :)
Attachment #8663779 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/d30c70405a0e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8663779 [details] [diff] [review]
fix broken CONFIG['DEBUG'] checks in moz.build files

Approval Request Comment
[Feature/regressing bug #]: bug 1186158
[User impact if declined]: Beta will not build on Mac debug when Aurora rolls over to beta.
[Describe test coverage new/current, TreeHerder]: No test coverage.  A very similar patch was landed as a bustage fix on beta yesterday and restored Mac debug builadability.
[Risks and why]: Virtually zero risk.
[String/UUID change made/needed]: None.
Attachment #8663779 - Flags: approval-mozilla-aurora?
Comment on attachment 8663779 [details] [diff] [review]
fix broken CONFIG['DEBUG'] checks in moz.build files

Sounds good, approved for uplift to aurora
Attachment #8663779 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.