1206801 - fix broken CONFIG['DEBUG'] checks in moz.build files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

These were supposed to be CONFIG['MOZ_DEBUG'].  webapprt doesn't use the
define it set up, however, so it was deleted rather than fixed.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix broken CONFIG['DEBUG'] checks in moz.build files

Credit to philor for pointing this out on IRC.

Comment 2

[Nathan Froyd [:froydnj]]

I pushed a slightly more conservative version of this patch to mozilla-beta to fix the build bustage there:

https://hg.mozilla.org/releases/mozilla-beta/rev/a91c7eca5508

I guess we'll need aurora uplift on this patch so aurora doesn't break on the next uplift to beta...

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8663779 [details] [diff] [review]
fix broken CONFIG['DEBUG'] checks in moz.build files

>These were supposed to be CONFIG['MOZ_DEBUG'].  webapprt doesn't use the
>define it set up, however, so it was deleted rather than fixed.
>
>diff --git a/webapprt/win/moz.build b/webapprt/win/moz.build

Looks like you could also do webapprt/moz.build since it has a DEFINES['MOZ_DEBUG'] that seems unnecessary :)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d30c70405a0e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d30c70405a0e

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8663779 [details] [diff] [review]
fix broken CONFIG['DEBUG'] checks in moz.build files

Approval Request Comment
[Feature/regressing bug #]: bug 1186158
[User impact if declined]: Beta will not build on Mac debug when Aurora rolls over to beta.
[Describe test coverage new/current, TreeHerder]: No test coverage.  A very similar patch was landed as a bustage fix on beta yesterday and restored Mac debug builadability.
[Risks and why]: Virtually zero risk.
[String/UUID change made/needed]: None.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8663779 [details] [diff] [review]
fix broken CONFIG['DEBUG'] checks in moz.build files

Sounds good, approved for uplift to aurora

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4353ea1e784e