Remove comment for div.talos-panel css for Talos tab results

RESOLVED FIXED

Status

P5
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jfrench, Assigned: jfrench)

Tracking

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
wlach
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Split out from PR 985, we may be able to remove the !important per the code comment in https://github.com/mozilla/treeherder/blob/a073fbc9af33b80bbfba0b26a2d46c26ae470cdb/ui/css/treeherder.css#L926-L928 now that bug 1094466 is fixed. This css is soon to be relocated to treeherder-info-panel.css.

It just made more sense to investigate and do that separately from the major split of the info-panel css in bug 1193804.

It's effect should be manifested in exiting Talos jobs in the Talos details pane.
(Assignee)

Comment 1

3 years ago
I re-checked, in its current markup we still need !important here, so I'll just update the line and remove the comment.

It's pretty obvious in the Talos pane when you remove the flag, the "Compare result against another revision with Perfherder" link will inherit display: flex and not line wrap.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Summary: Possibly remove the !important from div.talos-panel css for Talos tab results → Remove comment for div.talos-panel css for Talos tab results
(Assignee)

Comment 2

3 years ago
Created attachment 8664878 [details] [review]
PR 999

Tweak PR for review :)
Attachment #8664878 - Flags: review?(wlachance)
Comment on attachment 8664878 [details] [review]
PR 999

lgtm! thanks
Attachment #8664878 - Flags: review?(wlachance) → review+
(Assignee)

Comment 5

3 years ago
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.