Closed Bug 1206872 Opened 6 years ago Closed 6 years ago

[meta] Enable APZ on fennec on nightly builds

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

All
Android
defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file, 3 obsolete files)

This is a meta bug that tracks all the issues that need to be fixed before we can enable APZ on Fennec for nightly builds.
No longer blocks: 1203058
No longer blocks: 1213873
Depends on: 1223296
Attached patch Randall's patch (obsolete) — Splinter Review
Randall had a patch in his queue to enable C++ APZ by default. Posting it here since this bug is eventually going to be used to land the patch that does this. However we'll need to update the patch so that it only does this for nightly.
(Actually it would also be better to put the MOZ_ANDROID_APZ=1 into mobile/android/confvars.sh rather than configure.in)
Depends on: 1223609
Depends on: 1223612
Depends on: 1223614
Comment on attachment 8685605 [details] [diff] [review]
Randall's patch

Should we also add something to confvars with a NIGHTLY_BUILD check?
Attached patch Patch (obsolete) — Splinter Review
Yeah this is actually all that should be needed to flip it on. Seems to do the job locally at least.
Attachment #8685605 - Attachment is obsolete: true
Depends on: 1223937
No longer depends on: 1223937
No longer depends on: 1223609
No longer depends on: 1122804
No longer depends on: 1223614
No longer depends on: 1223612
Depends on: 1228216
Bug 1224015 landed. So you can push this when ready.
Flags: needinfo?(bugmail.mozilla)
We still need to do something about bug 1225508 - if you don't have any layout side fixes off the top of your head then I'm fine with landing the workaround that I have. I can do that tomorrow.
Flags: needinfo?(bugmail.mozilla)
Oh yeah. Probably a fix along the lines of your "My bad attempt at fixing it in layout" patch is the way to go. I'll work on getting that landable. The workaround is reasonable so you can land that if you want to go ahead before that's ready.
This part

https://hg.mozilla.org/integration/mozilla-inbound/rev/0aa2e79b9252#l4.13

of bug 1224015 appears to have fixed bug 1225508 for me. This makes sense to me. (I tested with and without that hunk.) So I think you are good to land without the workaround.
(Moving discussion to bug 1225508)
I think we're ready to turn this on. Happy thanksgiving!
Assignee: nobody → bugmail.mozilla
Attachment #8691619 - Attachment is obsolete: true
Attachment #8693007 - Flags: review?(mark.finkle)
Comment on attachment 8693007 [details] [diff] [review]
Enable APZ on nightly builds

Great work getting to this point!
Attachment #8693007 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/cc0dde3ac2a8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Depends on: 1229118
Depends on: 1230522
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.