Closed Bug 1206894 Opened 4 years ago Closed 4 years ago

Enable asynchronous dispatching of fetch events

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

This refactoring patch separates the preparation of the fetch event
object from its dispatching, so that consumers would be able to
dispatch the event asynchronously.
Assignee: nobody → ehsan
Blocks: 1198394
Comment on attachment 8663869 [details] [diff] [review]
Enable asynchronous dispatching of fetch events

Review of attachment 8663869 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libjar/InterceptedJARChannel.cpp
@@ +132,5 @@
> +  rv = dispatcher->Dispatch();
> +  if (NS_WARN_IF(NS_FAILED(rv))) {
> +    rv = ResetInterception();
> +    NS_WARN_IF_FALSE(NS_SUCCEEDED(rv),
> +        "Failed to dispatch the fetch event");

This should refer to ResetInterception failing.

::: netwerk/base/nsINetworkInterceptController.idl
@@ +25,5 @@
>   * the actual channel. nsIInterceptedChannel is expected to be implemented by objects
>   * which do not implement nsIChannel.
>   */
>  
> +[scriptable, uuid(40851f73-f799-4a22-a69b-05e0371ee373)]

Unnecessary.

::: netwerk/protocol/http/InterceptedChannel.cpp
@@ +68,5 @@
>      }
> +    rv = dispatcher->Dispatch();
> +    if (NS_WARN_IF(NS_FAILED(rv))) {
> +      rv = ResetInterception();
> +      NS_WARN_IF_FALSE(NS_SUCCEEDED(rv), "Failed to dispatch the fetch event");

This message should refer to ResetInterception failing.
Attachment #8663869 - Flags: review?(josh) → review+
(In reply to Josh Matthews [:jdm] from comment #2)
> ::: netwerk/base/nsINetworkInterceptController.idl
> @@ +25,5 @@
> >   * the actual channel. nsIInterceptedChannel is expected to be implemented by objects
> >   * which do not implement nsIChannel.
> >   */
> >  
> > +[scriptable, uuid(40851f73-f799-4a22-a69b-05e0371ee373)]
> 
> Unnecessary.

Unfortunately it's needed because of bug 1171721.  :(
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/6aabbc12983c
https://hg.mozilla.org/mozilla-central/rev/201ccc2e2e76
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1236686
You need to log in before you can comment on or make changes to this bug.