1206907 - GenerateWarning is outputing to Browser Console, not Web Console

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

This means that generally web-devs won't see WebGL warnings.

Maybe this relates to the entrypoint InitWithLegacyErrorReporting that we don't currently use.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Use-InitWithLegacyErrorReporting-for-now.patch

Comment 2

[Kelsey Gilbert [:jgilbert]]

This appears to go back to 33: http://hg.mozilla.org/mozilla-central/rev/8d6cff589e8f

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8663886 [details] [diff] [review]
0001-Use-InitWithLegacyErrorReporting-for-now.patch

Review of attachment 8663886 [details] [diff] [review]:
-----------------------------------------------------------------

This isn't the right thing. You probably want to call .TakeOwnershipOfErrorReporting() after Init(), which is the new way of doing things. Let me know if that doesn't work.

Sorry this stuff is in such an intermediate state. Needs fixing up and we haven't been able to resource it. :\

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Move-WebGL-warnings-back-to-the-web-console.patch

Comment 5

[Kelsey Gilbert [:jgilbert]]

This also works for me locally. Thanks :bholley.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ab1ef2f842a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ab1ef2f842a

Comment 8

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8663971 [details] [diff] [review]
0001-Move-WebGL-warnings-back-to-the-web-console.patch

Approval Request Comment
[Feature/regressing bug #]: Possibly bug 1070842?
[User impact if declined]: WebGL warnings and errors are printed in the Browser Console (which the vast majority of people don't check) instead of the Web Console (where devs know to check).
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8663971 [details] [diff] [review]
0001-Move-WebGL-warnings-back-to-the-web-console.patch

Taking it to simplify life of developers.  Should be in 42.0 beta 2.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f062d521fd58

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/56ae581cc67a