1206970 - Permafailing test_interfaces.html | AnimationPlaybackEvent should be defined on the global scope on the merge to beta 42

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=518096&repo=mozilla-beta

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: DisableAnimationPlaybackEvent on release

I have no idea whatsoever if this is what's actually necessary for fixing the permafail on beta, but it seems like it might work.

That's a good reason to post a patch, right? :)

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And a try run that may or may not work: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d6045c392cd

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Looks like the test_interfaces failures aren't happening in the try run.

Comment 4

[Phil Ringnalda (:philor)]

Had you run mochitest-4, where the test actually lives, you would have gotten all sorts of explosions though, since you're missing the {.

Comment 5

[Phil Ringnalda (:philor)]

I'm pretty sure having suggested the patch is the same as having reviewed it, so I landed it on beta with the { and r=smaug in https://hg.mozilla.org/releases/mozilla-beta/rev/8092ba9c3701

Comment 6

[Phil Ringnalda (:philor)]

You would think by now I would know that it's "check your own syntax" first, and only then "criticize someone else's syntax."

Bustage fix in https://hg.mozilla.org/releases/mozilla-beta/rev/de2645605ddd

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8663943 [details] [diff] [review]
DisableAnimationPlaybackEvent on release

https://hg.mozilla.org/releases/mozilla-beta/rev/de2645605ddd looks right ;)

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/644001c5eee0

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/aad7aaaa4476

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/644001c5eee0