Closed Bug 1206979 Opened 4 years ago Closed 4 years ago

Make FFmpeg PDM works with early version of libav

Categories

(Core :: Audio/Video: Playback, defect)

43 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(3 files)

Right now, we distinguish the different version based on the libavformat soname (53, 54 or 55) which is almost useless in determining which version of ffmpeg is present.

version 54 is used for ffmpeg 1.2 to 2.2
libav 1.0 also uses 54

If we were to only support version 55 and later ;we would restrict ffmpeg version that works very well.

We should change our selection of ffmpeg/libav based on the libavcodec instead (as this is what we're using) and be able to check the minor revision.
Assignee: nobody → jyavenard
Rename ; as really this is the ultimate goal of this bug
Summary: Limit ffmpeg to version we know works → Enable FFMpeg by default
Depends on: 1159171
And probably others. When multhreading decoding is enabled ; the frames dimensions were incorrectly set.
Attachment #8664074 - Flags: review?(edwin)
Summary: Enable FFMpeg by default → Make FFmpeg PDM works with early version of libav
Blocks: 1159171
No longer depends on: 1159171
Blocks: 1214943
Comment on attachment 8664073 [details] [diff] [review]
P1. Add method to determine which version of libavcodec is available.

This is a request for all patches in this queue.

Approval Request Comment
[Feature/regressing bug #]: 1214943
[User impact if declined]: Decode failure with early libAV version (ubuntu 12.04)
[Describe test coverage new/current, TreeHerder]: In central for a few weeks.
[Risks and why]: Low, we properly handle an API discrepancy. 
[String/UUID change made/needed]: None
Attachment #8664073 - Flags: approval-mozilla-aurora?
Comment on attachment 8664073 [details] [diff] [review]
P1. Add method to determine which version of libavcodec is available.

More checks for compatibility for ffmpeg. OK to uplift to aurora.
Attachment #8664073 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.