1206979 - Make FFmpeg PDM works with early version of libav

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

Right now, we distinguish the different version based on the libavformat soname (53, 54 or 55) which is almost useless in determining which version of ffmpeg is present.

version 54 is used for ffmpeg 1.2 to 2.2
libav 1.0 also uses 54

If we were to only support version 55 and later ;we would restrict ffmpeg version that works very well.

We should change our selection of ffmpeg/libav based on the libavcodec instead (as this is what we're using) and be able to check the minor revision.

Comment 1

[Jean-Yves Avenard [:jya]]

Rename ; as really this is the ultimate goal of this bug

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: P1. Add method to determine which version of libavcodec is available.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: P2. Get around libav 0.8.5 bug.

And probably others. When multhreading decoding is enabled ; the frames dimensions were incorrectly set.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: P3. Request S16 audio for libav 0.8 and earlier.

Comment 5

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=75a160984e50

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97a161382b60
https://hg.mozilla.org/integration/mozilla-inbound/rev/60560a4a7f41
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f7f4567efef

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/97a161382b60
https://hg.mozilla.org/mozilla-central/rev/60560a4a7f41
https://hg.mozilla.org/mozilla-central/rev/0f7f4567efef

Comment 8

[Jean-Yves Avenard [:jya]]

Comment on attachment 8664073 [details] [diff] [review]
P1. Add method to determine which version of libavcodec is available.

This is a request for all patches in this queue.

Approval Request Comment
[Feature/regressing bug #]: 1214943
[User impact if declined]: Decode failure with early libAV version (ubuntu 12.04)
[Describe test coverage new/current, TreeHerder]: In central for a few weeks.
[Risks and why]: Low, we properly handle an API discrepancy. 
[String/UUID change made/needed]: None

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8664073 [details] [diff] [review]
P1. Add method to determine which version of libavcodec is available.

More checks for compatibility for ffmpeg. OK to uplift to aurora.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8de5b42cda2d
https://hg.mozilla.org/releases/mozilla-aurora/rev/37cb06914ad6
https://hg.mozilla.org/releases/mozilla-aurora/rev/702f9f750869