Make Debug have a lower case name

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gasolin, Assigned: varghesethomase, Mentored)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [good first bug][mentor-lang=zh][lang=js])

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
According bug 1205588 comment, we'd make Debug have a lower case name. or it will possibly be misread as a constructor.


This issue is about findout and replace all `Debug` syntax to `debug`.

Ex: change:

```
var _debug = false;
var Debug = function() {};
....
```

to 

```
var _debug = false;
var debug = function() {};
(and related code)....
```
(Reporter)

Updated

3 years ago
tracking-b2g: --- → backlog
Whiteboard: [good first bug][mentor-lang=zh][lang=js]
(Reporter)

Updated

3 years ago
Mentor: gasolin
(Assignee)

Comment 1

3 years ago
Can I work on this? I am new to it, so it would be great if someone can guide me. I found many places where var Debug has been used. in both "apps/buetooth/" and "apps/settings" folder. If i can get to know which git branch to work in and which all files to update, it would be great.
(Reporter)

Comment 2

3 years ago
Of course! It's a good start when you found both Bluetooth and Settings need change `Debug` to `debug`.

Generally we fork https://github.com/mozilla-b2g/gaia ,modify and submit the pull request on github, than put the link in bugzilla attachment (click Add an attachment).


Once the pull request is on github, it will run some unit test to check if every changes looks fine. Or you may need check the apps/settings/test/unit to correct the tests
Assignee: nobody → varghesethomase
(Reporter)

Comment 3

3 years ago
Slides to help contribute FxOS Gaia project http://www.slideshare.net/gasolin/steps-to-contribute-to-firefox-os-2

Feel free to ask more information via bugzilla
I'll also on IRC @gasolin
Created attachment 8665785 [details] [review]
[gaia] varghesethomase:master > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8665785 - Flags: review?(gasolin)
(Reporter)

Comment 5

3 years ago
As discussion on IRC, please fix the conflict with gaia master first.

And You need squash the commits into 1 when the patch is ready to land

Please refer http://eragonj.me/blog/fxos-why-we-need-to-squash-commits.html for detail
(Reporter)

Comment 6

3 years ago
Comment on attachment 8665785 [details] [review]
[gaia] varghesethomase:master > mozilla-b2g:master

Thanks for make the change.
Please address above comments then set review again.


You can reach me on IRC or by reply this bug if you have any question.
Attachment #8665785 - Flags: review?(gasolin)
Created attachment 8669496 [details] [review]
[gaia] gasolin:issue-1206984 > mozilla-b2g:master
(Reporter)

Comment 8

3 years ago
Comment on attachment 8669496 [details] [review]
[gaia] gasolin:issue-1206984 > mozilla-b2g:master

Varghese the overall looks good to me, I pull your PR and fix a small nit at bluetooth/js/modules/transfer_manager.js

We are able to land the patch once all auto test are green. Thanks!
Attachment #8669496 - Flags: review+
(Reporter)

Comment 9

3 years ago
merged https://github.com/mozilla-b2g/gaia/commit/9bd1e7e3eded6ee7e10fb45b6b968f002b835f8c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.