Closed Bug 1207002 Opened 5 years ago Closed 5 years ago

Restrict MathML-related internal properties to only be accessible in UA sheets

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(3 files)

We are able to restrict internal properties to UA sheets only since bug 1069192. We probably should restrict some of the existing ones there, e.g. -moz-control-character-visibility and MathML ones.
Bug 1207002 part 1 - Use CSS property flag to restrict MathML-related internal properties.
Attachment #8668827 - Flags: review?(dbaron)
Bug 1207002 part 2 - Add pref to allow unsafe rules in content for testing.
Attachment #8668828 - Flags: review?(dbaron)
Bug 1207002 part 3 - Restrict -moz-control-character-visibility to UA sheets only.
Attachment #8668829 - Flags: review?(jfkthame)
Comment on attachment 8668829 [details]
MozReview Request: Bug 1207002 part 3 - Restrict -moz-control-character-visibility to UA sheets only.

:roc, this property was originally your idea, IIRC; what do you think of restricting it like this? Or should we continue to allow authors to override our default (which is set to flip soon...)
Attachment #8668829 - Flags: review?(jfkthame) → review?(roc)
Comment on attachment 8668827 [details]
MozReview Request: Bug 1207002 part 1 - Use CSS property flag to restrict MathML-related internal properties.

https://reviewboard.mozilla.org/r/21063/#review19025

::: layout/style/nsCSSParser.cpp
(Diff revision 1)
> -  // We only allow 'script-level' when unsafe rules are enabled, because
> -  // otherwise it could interfere with rulenode optimizations if used in
> -  // a non-MathML-enabled document. We also only allow math-display when

Please move this comment to nsCSSPropList.h (for 'script-level') rather than just deleting it.

r=dbaron with that
Attachment #8668827 - Flags: review?(dbaron) → review+
Could you explain why you want patch 2?
Flags: needinfo?(quanxunzhen)
For allowing the reftests of -moz-control-character-visibility (which is flagged in patch 3) to be run. If we do not want to restrict that property, or we can remove those tests, we would not need patch 2.
Flags: needinfo?(quanxunzhen)
I suggest not landing patches 2 and 3. Hopefully soon we'll flip the default, then some time after that we can just remove the property entirely since it will always be 'visible'.
Attachment #8668828 - Flags: review?(dbaron)
https://hg.mozilla.org/integration/mozilla-inbound/rev/05566a80f2ce3792ce5b14a7cf98bf7e131bbb1b
Bug 1207002 - Use CSS property flag to restrict MathML-related internal properties. r=dbaron
Summary: Restrict some internal properties to only accessible in UA sheets → Restrict MathML-related internal properties to only be accessible in UA sheets
Assignee: nobody → quanxunzhen
https://hg.mozilla.org/mozilla-central/rev/05566a80f2ce
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(In reply to Kohei Yoshino [:kohei] from comment #11)
> Posted the site compatibility doc just in case:
> https://www.fxsitecompat.com/en-US/docs/2015/several-internal-css-properties-
> have-been-removed/

Please note that it is decided not to remove -moz-control-character-visibility for now. You may want to correct the post.
Flags: needinfo?(kohei.yoshino)
Thanks for the info. Removed -moz-control-character-visibility from the doc.
Flags: needinfo?(kohei.yoshino)
You need to log in before you can comment on or make changes to this bug.