Refactor SearchEngineRow's update logic

NEW
Unassigned

Status

()

Firefox for Android
Awesomescreen
2 years ago
2 years ago

People

(Reporter: ally, Unassigned, Mentored)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good next bug])

(Reporter)

Description

2 years ago
With the introduction of saved searches to the search suggestions, then different counts of different types of suggestions depending on space and how many other suggestions are present, then separation of types based on their own prefs,  the logic has gotten (more) convoluted. 

Chenxia would like to see a "single function handle single method to handle updating the Suggestions view with both saved searches and search engine suggestions (pass in how many saved search suggestions there are, and how many total suggestion slots there are)"

We'll need to track which suggestions are which type and in what order they should be displayed. an ArrayList of <String, type> might do. Order matters for both types, so order of insertion would determine correctness.

Before displaying a different type of suggestion we'll need to remember to hide the recycled suggestions. Might be the thorniest part. 

In terms of difficult, I imagine someone with at least a semester of data structures could probably handle this.
(Reporter)

Updated

2 years ago
Mentor: ally@mozilla.com, michael.l.comella@gmail.com
Whiteboard: [good next bug]
(Reporter)

Updated

2 years ago
Blocks: 1086952

Updated

2 years ago
Blocks: 1206202

Updated

2 years ago
No longer blocks: 1086952
You need to log in before you can comment on or make changes to this bug.