1207022 - Refactor SearchEngineRow's update logic

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Allison Naaktgeboren :ally]

With the introduction of saved searches to the search suggestions, then different counts of different types of suggestions depending on space and how many other suggestions are present, then separation of types based on their own prefs,  the logic has gotten (more) convoluted. 

Chenxia would like to see a "single function handle single method to handle updating the Suggestions view with both saved searches and search engine suggestions (pass in how many saved search suggestions there are, and how many total suggestion slots there are)"

We'll need to track which suggestions are which type and in what order they should be displayed. an ArrayList of <String, type> might do. Order matters for both types, so order of insertion would determine correctness.

Before displaying a different type of suggestion we'll need to remember to hide the recycled suggestions. Might be the thorniest part. 

In terms of difficult, I imagine someone with at least a semester of data structures could probably handle this.

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.