Closed Bug 1207038 Opened 5 years ago Closed 4 years ago

Backout workaround of bug 1156475 for Marionette shutdown hang

Categories

(Testing :: Firefox UI Tests, defect)

Version 3
defect
Not set

Tracking

(firefox45 fixed, firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(2 files)

Most likely as of today the content shutdown hang of Marionette will be fixed. Once a new release of Marionette client has been done we should backout the fix as landed on bug 1156475 on all branches.
Depends on: 1209441
I don't want to revert those changes now given that we still have bug 1202663 open which can also cause a hang in the screenshot method during tearDown. Lets wait for it.
Depends on: 1202663
Product: Mozilla QA → Testing
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attached file Github PR
Attachment #8716407 - Flags: review?(mjzffr)
Attachment #8716407 - Flags: review?(mjzffr) → review+
On bug 1246187 we see failures for Aurora in the lines we remove here. So I would like to get this backported to that branch too. Given that we do not run our update tests for releases via Marionette yet, this might also affect beta.

I merged the PR to the mozilla-central branch:
https://github.com/mozilla/firefox-ui-tests/commit/ad3805043934d228ad684506ea2db117ebf34441

If if all update tests are passing today for Nightly I will backport it to the other branches and also get it landed on hg.mo.
Attached patch Patch for hg.moSplinter Review
Same patch with only paths adjusted. Taking over r+.
Attachment #8717815 - Flags: review+
Attachment #8716407 - Flags: checked-in+
Please land attachment 8717815 [details] [diff] [review] on inbound with DONTBUILD given that no in-tree CI makes use of it yet.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/log?rev=297c0de47d32
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
The backports in our external github repo work fine, so we also have to sync those testonly changes for mozilla-aurora and mozilla-beta. Please land with DONTBUILD given that only external tests are triggered.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/f966bbaa5628
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.