Closed Bug 1207061 Opened 4 years ago Closed 4 years ago

update graphite2 library to release 1.3.3

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(2 files)

As a followup to bug 1200098, there is a further bug-fix release that we should take. From the release announcement:

=====
The changes are:

1.3.3
    . Slight speed up in Collision Avoidance
    . Remove dead bidi code
    . Bug fixes
        . Between pass bidi reorderings and at the end
        . Decompressor fuzz bugs
        . Other fuzz bugs
=====
Attachment #8664120 - Flags: review?(jdaggett)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Here's a simple reftest that fails badly under 1.3.2, and is fixed by the bidi fixes in the new release.
Attachment #8664121 - Flags: review?(jdaggett)
:jtd, review ping?
Flags: needinfo?(jdaggett)
Attachment #8664120 - Flags: review?(jdaggett) → review+
Attachment #8664121 - Flags: review?(jdaggett) → review+
Flags: needinfo?(jdaggett)
https://hg.mozilla.org/mozilla-central/rev/1af5f68be39a
https://hg.mozilla.org/mozilla-central/rev/a33990730ee4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8664120 [details] [diff] [review]
Update graphite2 library to release 1.3.3

Approval Request Comment
[Feature/regressing bug #]: Bug 1200098 updated the graphite2 library to v1.3.2, which was a substantial update with significant new functionality; since then, a further bug-fix v1.3.3 has been released.

[User impact if declined]: Possibility of incorrect rendering with certain bidi fonts; possible exposure to recently-fixed fuzz bugs in the graphite2 lib

[Describe test coverage new/current, TreeHerder]: Existing tests for graphite2 font shaping functionality; new reftest for the bidi bug found in v1.3.2.

[Risks and why]: Low-risk update to latest release, which is primarily a bug-fix based on extensive fuzz-testing by upstream.

[String/UUID change made/needed]: n/a
Attachment #8664120 - Flags: approval-mozilla-aurora?
Comment on attachment 8664120 [details] [diff] [review]
Update graphite2 library to release 1.3.3

Approved for uplift to aurora; has new test coverage
Attachment #8664120 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.