1207071 - remove plugins references in talos

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Julien Pagès (:parkouss)]

So, looking at bug 1206415 comment 4, the plugins are obsolete and we should remove them.

So I think there are two files that we should change:

 - testing/mozharness/mozharness/mozilla/testing/talos.py
 - testing/talos/talos.json

Comment 1

[Julien Pagès (:parkouss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb4982ddd8eb

Comment 2

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1207071 - remove plugins references in talos. r=jmaher

Bug 1207071 - remove plugins references in talos. r=jmaher

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8665518 [details]
MozReview Request: Bug 1207071 - remove plugins references in talos. r=jmaher

https://reviewboard.mozilla.org/r/20247/#review18229

this is great!  cleanup is awesome to see.

Comment 4

[Julien Pagès (:parkouss)]

So, I am unable to remove the "--system-bits" option that is used on try (and it was only useful for plugins;):

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/testing/talos.py#103

If I remove that, builds are broken. This is because it appears in the the log, so the thing that call the talos mozharness stuff define that somewhere, and we can't remove option definitions from the talos.py file until we removed that from that *thing*.

I found something that may be that thing, in build-central:

https://dxr.mozilla.org/build-central/source/buildbotcustom/misc.py#2420

:armenzg, can you help me here so I can remove the option definitions from the talos.py mozharness file (note that there are multiple options that we don't use in there (first link)) ? Am I on the right track, and what should I do to make changes here if it is the case ?

Comment 5

[Julien Pagès (:parkouss)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ad005811c5ec45704250cfb90e003426701541
Bug 1207071 - remove plugins references in talos. r=jmaher

Comment 6

[Julien Pagès (:parkouss)]

leave-open until we know what we do for the option definitions.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2ad005811c5

Comment 8

[Julien Pagès (:parkouss)]

:armenzg, could you look at comment 4 please ? I forgot to NI you. :)

Comment 9

[Armen [:armenzg]]

What happens if we call talos on a release repo without --system-bits? Is it a mandatory option?

If we can call talos on release branches without --system-bits and we don't fail then we're OK to remove that line from misc.py (since it affects talos jobs across the board).

If this is not the case, I suggest turning --system-bits an optional parameter and uplift before the buildbotcustom change.

Does this help?

Comment 10

[Julien Pagès (:parkouss)]

Oh, yep, I am starting to understand thanks!

So, should I look into each branch in https://hg.mozilla.org/releases ?

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

we only run talos on :
try
mozilla-beta
mozilla-aurora
mozilla-central
mozilla-inbound
fx-team
<related trunk based twigs>

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

I wanted to see if we have anything left to do here.  It sounds like there is some cleanup we can do at the mozharness level.  :parkouss, feel free to cl hime in, otherwise, I will look into this early next week.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

it seems as though we could remove this from buildbot-custom, then once that is deployed, we can clean up the mozharness system-bits.

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: byebye_systembits.patch

lets see if this works as it is deployed!

Comment 15

[Justin Wood (:Callek)]

Comment on attachment 8701181 [details] [diff] [review]
byebye_systembits.patch

Review of attachment 8701181 [details] [diff] [review]:
-----------------------------------------------------------------

I'm assuming that on no tree still active we *require* that bit in the config. If that is true then we'll be fine this way.

Comment 16

[Joel Maher ( :jmaher ) (UTC -8)]

thanks Callek:
https://hg.mozilla.org/build/buildbot-configs/rev/23c34b6f0538

Comment 17

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: bbcustom_nosystembits.patch

we need to fix buildbotcustom repo first, then do the buildbot-configs repo.  This passes |tox| locally.

Comment 18

[Justin Wood (:Callek)]

Comment on attachment 8701512 [details] [diff] [review]
bbcustom_nosystembits.patch

Review of attachment 8701512 [details] [diff] [review]:
-----------------------------------------------------------------

From code inspection, I see no reason that this would fail from a buildbot perspective.

Comment 19

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/buildbotcustom/rev/6104875a4a3a

Comment 20

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/6104875a4a3a

Comment 21

[Joel Maher ( :jmaher ) (UTC -8)]

and the buildbot-configs patch again:
https://hg.mozilla.org/build/buildbot-configs/rev/6f21a76b0df7

Comment 22

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.