Closed
Bug 1207100
Opened 9 years ago
Closed 9 years ago
Fixed nsEdgeReadingListExtractor.cpp compilation on GCC.
Categories
(Firefox :: Migration, defect)
Tracking
()
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
4.43 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
I get a lot of errors like (jump over variable declaration is illegal):
0:01.44 /home/jacek/mozilla/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp:171:1: error: jump to label ‘CloseDB’ [-fpermissive]
0:01.44 CloseDB:
0:01.44 ^
0:01.44 /home/jacek/mozilla/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp:20:10: note: from here
0:01.44 goto CloseDB; \
0:01.44 ^
0:01.45 /home/jacek/mozilla/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp:139:3: note: in expansion of macro ‘NS_HANDLE_JET_ERROR’
0:01.45 NS_HANDLE_JET_ERROR(err)
0:01.45 ^
0:01.45 /home/jacek/mozilla/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp:143:11: note: crosses initialization of ‘wchar_t titleBuffer [1024]’
0:01.45 wchar_t titleBuffer[MAX_TITLE_LENGTH] = { 0 };
0:01.45 ^
0:01.45 /home/jacek/mozilla/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp:142:11: note: crosses initialization of ‘wchar_t urlBuffer [4168]’
Attachment #8664166 -
Flags: review?(mak77)
|
||
Updated•9 years ago
|
Attachment #8664166 -
Flags: review?(mak77) → review?(gijskruitbosch+bugs)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8664166 [details] [diff] [review] fix Review of attachment 8664166 [details] [diff] [review]: ----------------------------------------------------------------- rs=me picky compiler is picky. :-\
Attachment #8664166 -
Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/a0ecccc081ef
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in
before you can comment on or make changes to this bug.
Description
•