Closed
Bug 1207121
Opened 10 years ago
Closed 10 years ago
Guard ctx._resolve with ctx.fetch
Categories
(Firefox OS Graveyard :: Gaia::L10n, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
When bug 1204086 lands, we should be able to move ctx.fetch into ctx._resolve, instead of doing it in the Service.
The reason why this used to be in the Service was so that we only call ctx.fetch once per call to translateFragment (which called ctx.resolveEntity many times over). With bug 1204086, we don't have to worry about too many promises being resolved because ctx.resolveEntities takes care of that logic for us.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8664507 [details] [review]
Pull request
lgtm!
Attachment #8664507 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•