Closed
Bug 1207148
Opened 9 years ago
Closed 9 years ago
Remove unused wait cursor assets from ui/img
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jfrench, Assigned: jfrench)
Details
Attachments
(1 file)
We have a bunch of unused wait cursor assets in ui/img, and we now use bootstrap's fa-spinner for our wait cursor, so let's remove them. https://github.com/mozilla/treeherder/blob/afe16b0c000296877595706fc000a074f8d9e8e5/ui/css/treeherder.css#L828-L830 In keeping with our goal for more modest PR requests, I'm intentionally doing this outside the scope of the larger splitting changes in bug 1193804.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
Tweak PR for review. nb. I misstated the above comment 0, glyphicon halflings is bootstrap's native icon set :)
Attachment #8664207 -
Flags: review?(wlachance)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8664207 [details] [review] PR 987 lgtm!
Attachment #8664207 -
Flags: review?(wlachance) → review+
|
||
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/04fdb94746024c890b515efd032508c3badf39d1 Bug 1207148 - Remove unused UI wait cursor assets
|
|
Assignee | |
Comment 4•9 years ago
|
||
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•