1207153 - GLBlitHelper::BlitEGLImageImage restores texture binding to wrong target

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jamie Nicol [:jnicol]]

GLBlitHelper::BlitEGLImageImage uses the texture target GL_TEXTURE_2D. Before using it it saves the texture currently bound to the target, then rebinds that texture when finished. However, the code currently rebinds the texture to the target GL_TEXTURE_EXTERNAL_OES rather than GL_TEXTURE_2D. This causes a GL_INVALID_OPERATION error, since we are binding the texture to a target other than the target which it was first bound to.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Patch v1

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8664206 [details] [diff] [review]
Patch v1

Review of attachment 8664206 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right to me. We get the 2D binding above, but try restoring it to external, which was definitely wrong.

Comment 3

[Jamie Nicol [:jnicol]]

I've verified it compiles and runs locally. Simple change so doesn't need additional try testing.

Affects all branches but since we weren't seeing any negative consequences we probably just want to land this on nightly?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/edf7e8ac4a7d

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/edf7e8ac4a7d